From: Simon Marchi <simon.marchi@ericsson.com>
To: Pedro Alves <palves@redhat.com>, <gdb-patches@sourceware.org>
Subject: Re: [PATCH 2/2] Fix solib-display.exp remote check
Date: Wed, 04 May 2016 13:37:00 -0000 [thread overview]
Message-ID: <5729FB06.70800@ericsson.com> (raw)
In-Reply-To: <ce745285-eee7-f284-69b8-44378f513ae4@redhat.com>
On 16-05-02 02:30 PM, Pedro Alves wrote:
> OK.
>
> As mentioned in the other thread, I think it'd be nice to add
> bits of the info you found about why "run" is required.
> Thanks,
> Pedro Alves
Ok, I pushed both patches, with the comment added in this one:
From 02e370d94ee3abc6f910602e79c6d4515d9c720d Mon Sep 17 00:00:00 2001
From: Simon Marchi <simon.marchi@ericsson.com>
Date: Wed, 4 May 2016 09:27:34 -0400
Subject: [PATCH] Fix solib-display.exp remote check
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
This test currently uses [is_remote target] to check if the test is
supported. This is not quite correct, as the limitation is actually
that it requires support for "running", ruling out stub-like targets.
Therefore, it should check for use_gdb_stub.
This has no visible effect right now, but it will once we make the
native-gdbserver board non-dejagnu-remote.
gdb/testsuite/ChangeLog:
* gdb.base/solib-display.exp: Check for [use_gdb_stub] instead
of [is_remote target],
---
gdb/testsuite/ChangeLog | 5 +++++
gdb/testsuite/gdb.base/solib-display.exp | 19 ++++++++++++++++++-
2 files changed, 23 insertions(+), 1 deletion(-)
diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index e3830b6..e1fdd38 100644
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,5 +1,10 @@
2016-05-04 Simon Marchi <simon.marchi@ericsson.com>
+ * gdb.base/solib-display.exp: Check for [use_gdb_stub] instead
+ of [is_remote target],
+
+2016-05-04 Simon Marchi <simon.marchi@ericsson.com>
+
* lib/gdb.exp (use_gdb_stub): New procedure.
2016-05-03 Yunlian Jiang <yunlian@google.com>
diff --git a/gdb/testsuite/gdb.base/solib-display.exp b/gdb/testsuite/gdb.base/solib-display.exp
index 7f65617..a82ec2e 100644
--- a/gdb/testsuite/gdb.base/solib-display.exp
+++ b/gdb/testsuite/gdb.base/solib-display.exp
@@ -28,7 +28,24 @@
# (and thus aren't affected by shared library unloading) are not
# disabled prematurely.
-if { [skip_shlib_tests] || [is_remote target] } {
+if { [skip_shlib_tests] } {
+ return 0
+}
+
+# This test is currently not supported for stub targets, because it uses the
+# start command (through gdb_start_cmd). In theory, it could be changed to
+# use something else (kill + gdb_run_cmd with a manual breakpoint at main).
+# However, when we try that with the native-gdbserver board, we see that the
+# test fails and gdb outputs this upon connection:
+#
+# warning: Unable to display "a_global": No symbol "a_global" in current context.
+# warning: Unable to display "b_global": No symbol "b_global" in current context.
+# warning: Unable to display "c_global": No symbol "c_global" in current context.
+#
+# This is because the initial stop is done before the shared libraries are
+# loaded.
+
+if { [use_gdb_stub] } {
return 0
}
--
2.8.2
next prev parent reply other threads:[~2016-05-04 13:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-02 18:18 [PATCH 1/2] Introduce procedure use_gdb_stub Simon Marchi
2016-05-02 18:18 ` [PATCH 2/2] Fix solib-display.exp remote check Simon Marchi
2016-05-02 18:30 ` Pedro Alves
2016-05-04 13:37 ` Simon Marchi [this message]
2016-05-02 18:28 ` [PATCH 1/2] Introduce procedure use_gdb_stub Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5729FB06.70800@ericsson.com \
--to=simon.marchi@ericsson.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).