From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mailsec215.isp.belgacom.be (mailsec215.isp.belgacom.be [195.238.22.111]) by sourceware.org (Postfix) with ESMTPS id 157B33858D3C for ; Sun, 27 Nov 2022 20:16:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 157B33858D3C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=skynet.be Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=skynet.be DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=skynet.be; i=@skynet.be; q=dns/txt; s=rmail; t=1669580196; x=1701116196; h=message-id:subject:from:to:date:in-reply-to:references: mime-version:content-transfer-encoding; bh=jzPNzonk7/7H3TV9EwEtZsRGV5gN9dgglUAGbr6z9hk=; b=isednfYhfDfBb+Xrjah0yaitOXGoY8fyqsPSF6BhvdvN2kKRKmotKlEj wBkNwRFiBUODYgwAYkemvk7Ey5OEjaTzPycHXBfBYvBU4wqNrx/gJnMlm fv7quQjDdLdhsZZS9D13wm43jsSZRg4nTGKv20LqSVaTc1ikdmZaf80mW g=; X-ExtLoop: 1 X-IPAS-Result: =?us-ascii?q?A2BMAQB5xINj/1uGgG0NTR4BAQsSDEAJgTsLhQmETpEen?= =?us-ascii?q?TSBfg8BAQEBAQEBAQEJRAQBAYUFAoUIJjUIDgECBAEBAQEDAgMBAQEBAQEDA?= =?us-ascii?q?QEGAQEBAQEBBgQBgRyFL4J7IoN9AQEBAyMEYgsOCgICJgICVwYBErMben8zg?= =?us-ascii?q?QGEcZplgWeBFCyJBoNghDA3gVVEhAg3PogbgmcEmEEcNwMZKx1AAwttCkUbW?= =?us-ascii?q?A4JHxwOFw0FBhIDIGwFCjcPKC9kKxwbB4EMKigVAwQEAwIGEwMiAg0pMRQEK?= =?us-ascii?q?RMNKydvCQIDImUFAwMEKCwDCSEfBxYRJDwHVjoBBAMCDyA4BgMJAwIiVHMuE?= =?us-ascii?q?RUFAwsVJQgFSwQIOQUGUhICChEDEg8GJkUOSD45FgYncw4OEwNdgWkENYFxC?= =?us-ascii?q?mCZa4Z4oxOfXTQHg2yBSQYMnnwyg2WeJocOLZcKIKdYgWMBghNtgzpSKJxxd?= =?us-ascii?q?DsCBwsBAQMJih8BAQ?= IronPort-PHdr: A9a23:SC+ATBG5Xe6f/94iPGGcAp1Gf1FLhN3EVzX9CrIZgr5DOp6u447ld BSGo6k30BmWBc6CsK4My7KP9fy6AipYudfJmUtBWaQEbwUCh8QSkl5oK+++Imq/EsTXaTcnF t9JTl5v8iLzG0FUHMHjew+a+SXqvnYdFRrlKAV6OPn+FJLMgMSrzeCy/IDYbxlViDanbr5+M hq7oR/Tu8UKjoduN6g8xxTUqXdMZ+ha2HlkKF2Nkxvy/Mu84IJv/yFNsP896sBMVrn3cb4lR rJCFjQmNG415MzvtRbdSAaE+2URXGYLnBdWGgbJ9B71UIv/vSv8rep9xTKVPdbqQrAuWDSt9 LlkRRn1gyoaLTE58WXXisttjKJHpR+quhJyz5LIbIyTKfFzeL7Wc9EHSmpbRstfVDFPDIOiY YUBDeUBM/pXoIfyqFUBtha+GQuhCfnzxjNUnHL736s32PkhHwHc2wwgGsoDvm7UrNX0MKcSU Pi1zLHWwj7eb/xZwy396I/RchA8oPGDQ6hwcdHMwkQoDwPFjlSQqYjkPzONzuQCrXKX7uR6W uK1jG4nshxxojmxycc2kYnEnZkVylPE9CV/3ok1Oce0R1VlbtO9FpZbqi6VOZdsTMw4X2Fop Dg1yqcAuZOjYiQG1pcqygLQZvCbb4SF4BLuWemMLDl4mH5od72xiRav/EWuzuDxSMe63UhEo ydGkdTBuHEA2hzd58WITvZw/0Gs0iuM2QDL8uxIPFw4mK7BJ5I83LI9lYAfvVnNEyL5gkn7i LKae0M58eay8evneK/pppqEOo9xjQHxL7ohl9SkAeQ9LggOR2+b+fmg1LH7/U32XrFKjvoun 6bdrZzXIdoXqrSkDwJU0Ysv8QuzAy273Nkcm3YLNFNFeBSZgIj1I1zCPez0APOlj1ixjjtmx OrKMqDvD5jCNHTOlKrtca5460FGyQozyd5f54hTCrEEOP/zQk/xtN3cDh84Kwy02/joBM9z1 4wEQ2KPBbaZML7TsVCW/OIvOPKBZJQWuDf9Lfgq+eLugWUillADZaWp24AYZ2iiHvt6O0WZf WbsgtAZHGsUpgY+VvDliEWeUT5PYHa/R7k85jA+CI28F4fDRZuggKeA3Ce+BJJWfGNGBkqQH njyb4mEQesDaDqOIs99lTwJTbehRJI62h23rA/10aZnIfbU+iIGrpLuz8N15+rOlREo6TN7E cqc3HuXT25qhG8IQCU23K8s6XB6n2yC1K9+y9lRD9dT5rsdSQY/PITf5/d7DtnoWUTKd4HNA FmqSJC+CC06Tt8q68QJflx2FsqrlB2F2DClUJEPkLnePJw19qPEx3W5GM9nzG/b1aQ7lBFyW stOMWy+nqM56AHJAJfUkkiDjI6xdrUa0TKL/mrVnjnGh11RTAMlCfaNZnsYfEaD9bzE IronPort-Data: A9a23:PPCxi6MWFv0gdH/vrR3BlsFynXyQoLVcMsEvi/4bfWQNrUp0gWMAx 2cfXGzUO/yPYzenfohzOYu18EgB7JKGnN5mQHM5pCpnJ55oRWopJjg4wmPYZX76whjrFRo/h ykmQoCcappyFxcwnz/1WpD5t35wyKqUcbT1De/AK0hZSBRtIMsboUsLd9UR38g537BVPyvX4 Ymo+pSFZwf8s9JJGjt8B5yr+UsHUMva5WtwUmwWPZhjoFLYnn8JO5MTTYnZw6zQG9Q88kaSH o4v/Znhlo/r105F5uCNzt4XRnY3rov6ZmBivJb5t5+K2XCurgRqukoy2WF1hU1/011llPgpo DlBWADZpQoBZsXxdOohvxZwOihaMq5K3638fmWbk+PDiGr3WUfi6qA7ZK02FdVwFudfMjgfr 7pBdmBLN1ba1tfeLLCTE7E9wJ15fI+yZ99Z6ygIITLxVJ7KRbjbQ6TO5MdA0XEvj9pJBOvfa tACQSFsfRLNf1tFNz/7DbplzL3w3SamKVW0rnq6+o0+uXqDyzV8zZXob97XQPm0b+p8yxPwS mXuuj6R7gshHMeezDOf8Vq3h+rGhyC9U4t6PLK0/LtyiUGYxmEIIAYRSEGwrOawkEP4XMhQQ 3H44QJ/9O5rrxDuF4OtGkTg8TiNsgUYHtZBFas78xnLwKfQ7A+SAW1CRDMphMEaifLajAcCj jeh9+4FzxQ12FFJYRpxPYt4Yd9/1eb54IPCieI5odM53uTe IronPort-HdrOrdr: A9a23:s5+rNKwKaB2auNhcBr1XKrPwOb1zdoMgy1knxilNoHtuA6mlfq GV/MjzuiWatN98YhwdcJW7VpVoIkmsl6Kdg7N7AV7KZmCPhILrFuBfBODZqQEIdReTygcQ79 YCT5RD X-IronPort-Anti-Spam-Filtered: true Received: from 91.134-128-109.adsl-dyn.isp.belgacom.be (HELO [192.168.1.19]) ([109.128.134.91]) by relay.proximus.be with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Nov 2022 21:16:34 +0100 Message-ID: <572bb46b3885ec4a0cc66bf687d05a716187a36a.camel@skynet.be> Subject: Re: [RFA] fix leak in gdb_environ From: Philippe Waroquiers To: Simon Marchi , gdb-patches@sourceware.org Date: Sun, 27 Nov 2022 21:16:32 +0100 In-Reply-To: References: <20221127182504.867308-1-philippe.waroquiers@skynet.be> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Sun, 2022-11-27 at 13:41 -0500, Simon Marchi wrote: > > On 11/27/22 13:25, Philippe Waroquiers via Gdb-patches wrote: > > valgrind reports a leak when assigning a gdb_environ to another gdb_environ. > > The memory allocated for the target gdb_environ env variables is not released. > > The gdb_environ selftest reproduces the leak (see below). > > Fix the leak by clearing the target gbd_environ before std::move-ing the > > gbd_environ -> gdb_environ > > Otherwise: > > Approved-By: Simon Marchi Thanks for the review, pushed with the tag added.