From: Bernhard Heckel <bernhard.heckel@intel.com>
To: Yao Qi <qiyaoltc@gmail.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 2/4] Fortran, typeprint: Take level of details into account when printing elements of a structure.
Date: Thu, 12 May 2016 12:42:00 -0000 [thread overview]
Message-ID: <57347A02.4000802@intel.com> (raw)
In-Reply-To: <86futncwgb.fsf@gmail.com>
On 12/05/2016 14:06, Yao Qi wrote:
> Bernhard Heckel <bernhard.heckel@intel.com> writes:
>
>> - f_type_print_base (TYPE_FIELD_TYPE (type, index), stream, show,
>> - level + 4);
>> - fputs_filtered (" :: ", stream);
>> - fputs_filtered (TYPE_FIELD_NAME (type, index), stream);
>> - f_type_print_varspec_suffix (TYPE_FIELD_TYPE (type, index),
>> - stream, 0, 0, 0, 0);
>> fputs_filtered ("\n", stream);
>> - }
>> - fprintfi_filtered (level, stream, "End Type ");
>> - fputs_filtered (TYPE_TAG_NAME (type), stream);
>> + for (index = 0; index < TYPE_NFIELDS (type); index++)
>> + {
>> + f_type_print_base (TYPE_FIELD_TYPE (type, index), stream, show - 1,
>> + level + 4);
> I read this patch again, and happen to see that we pass "show - 1" to
> f_type_print_base instead of "show". I think the change is correct, but
> it shouldn't fall in this patch, right?
>
Yes, you are right. Show -1 should not go into this patch.
Thx
Intel Deutschland GmbH
Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de
Managing Directors: Christin Eisenschmid, Christian Lamprechter
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928
next prev parent reply other threads:[~2016-05-12 12:42 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-10 14:16 [PATCH 0/4] Fortran, typeprint Bernhard Heckel
2016-05-10 14:16 ` [PATCH 2/4] Fortran, typeprint: Take level of details into account when printing elements of a structure Bernhard Heckel
2016-05-11 12:09 ` Yao Qi
2016-05-12 12:06 ` Yao Qi
2016-05-12 12:42 ` Bernhard Heckel [this message]
2016-05-10 14:16 ` [PATCH 3/4] Fortran, typeprint: Decrease level of details " Bernhard Heckel
2016-05-11 13:40 ` Yao Qi
2016-05-12 8:00 ` Bernhard Heckel
2016-05-12 12:45 ` Yao Qi
2016-05-10 14:16 ` [PATCH 1/4] Fortran, typeprint: Fix wrong indentation when ptype nested structures Bernhard Heckel
2016-05-11 11:58 ` Yao Qi
2016-05-11 11:59 ` Yao Qi
2016-05-10 14:18 ` [PATCH 4/4] Fortran, typeprint: Forward level of details to be printed for pointers Bernhard Heckel
2016-05-11 13:42 ` Yao Qi
2016-05-13 14:27 ` Yao Qi
2016-05-13 15:55 ` Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57347A02.4000802@intel.com \
--to=bernhard.heckel@intel.com \
--cc=gdb-patches@sourceware.org \
--cc=qiyaoltc@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).