From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 6113A3858D34 for ; Wed, 6 Mar 2024 14:07:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6113A3858D34 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 6113A3858D34 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1709734044; cv=none; b=qTaN6otEMjll0PKRe9embFC9CL9LtZLHimzlD+rOd3j5ilNjTPLF/L9CxTIiN6bD+U+ZV9kRe/RO5kpy7jtBYgrDnJjNqyK1ikI7lf443WnkMovcOOb16u5/UTGjp/Rk5DC18cHUOKErBNC9xTEvE4Z6Hl1uWxe8q0zqzHN1v14= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1709734044; c=relaxed/simple; bh=LnRGCCc2xJ8tcTR4CsaHs2ygJBCk/g2YB4dsVBSr0fA=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=hf/82V+KFH5t2SPyjXpdUmy0ofhZs/sjDIBE93caE1vM33Tcu8dnenMIw+FUn38FpMZuhFxIgR9oM81j0a0HgaSZo0UvoNIQ75mgd55oBNE1TYsiuUgXdTb+E1HYLWqk24OFSx2yIa9tlcNLpAlcwwhJBQqfs71YuEACd5bddo8= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1709734041; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4rd/1jw6BSlQ44fFg0DG/x/QBXPu1nQXyVa37AFL2kM=; b=J+L7H81bI26uJjXrg8s93QCIxL486FB2/ckrRkMW/bFthzK9/0ON8j4R6AsybPJXvStuJ0 q8fKjSoBo1+ie4+mzOE2rtiaEAmjb8dZFXHDqCV6dg0bC6I/pdY78YUPr5toxa7RLQ4PL7 aCadXnKwLmLRQHVarTczDSxAE7xoJh4= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-623-QT2kEn9WNrqvJcXrJ9WoeA-1; Wed, 06 Mar 2024 09:07:20 -0500 X-MC-Unique: QT2kEn9WNrqvJcXrJ9WoeA-1 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-412fb99c892so1774475e9.1 for ; Wed, 06 Mar 2024 06:07:20 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709734039; x=1710338839; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=4rd/1jw6BSlQ44fFg0DG/x/QBXPu1nQXyVa37AFL2kM=; b=WVmiwIcVm2eH8l5EgdD2Kz9dOgWxqp+reMhuVLaoI95j8kVEZ+7Lph8LyopWBZpxSj Mhk5B0ZRXg4MUtO7vzZZdTWYbmpdRLHnCHXYqHyZvktYXOO6owMs5ZJQRa/jCA3anGGE 3HYXdkQtOVgly+ThwkHwL7bdNBQ10ajlEEVKRPcncHAboFdLQxcSU2OVvLHVXts+sU3G 0JmxpAUARSESdmtRlMCttnINJWpF9zYQcWzRFXEzUwfMUWGEOUFa3JSvaSbA493QKFHL DZt0GQ9/WMyB39zfRCafXyIAo73JMGDOK/MjnaoaEj3K5Yel4+MWnT1ceCjMFmIAbcK6 D78w== X-Gm-Message-State: AOJu0YyIlUPi5ABiV0YU5jWqdDE5LFRgL2VH9FP5waIOzJUwLYMp+y+b wyMqhjTNRc6pSQwSZCWxxRoXcXkW8jLpHJrin3hh/eEVOl/4NtvQiUFr8gkD/GuDgx/NTqVQ8gd ir/ZW7pK+3wV0dYzd2hrED2tlXbE4fuoVWi70lBX1qA7F2lloQmGdte3QFSY= X-Received: by 2002:a05:600c:b90:b0:412:f556:d240 with SMTP id fl16-20020a05600c0b9000b00412f556d240mr1350725wmb.28.1709734039354; Wed, 06 Mar 2024 06:07:19 -0800 (PST) X-Google-Smtp-Source: AGHT+IEWK34E5YEtY83H8GM7hQgvLAS7rFHfX8NOl+zATLzdS971eQ5R5/hbhEUGa5CW0hEqXmOS1w== X-Received: by 2002:a05:600c:b90:b0:412:f556:d240 with SMTP id fl16-20020a05600c0b9000b00412f556d240mr1350711wmb.28.1709734038988; Wed, 06 Mar 2024 06:07:18 -0800 (PST) Received: from [192.168.0.129] (ip-94-112-227-180.bb.vodafone.cz. [94.112.227.180]) by smtp.gmail.com with ESMTPSA id m19-20020a056000181300b0033d3b8820f8sm17622079wrh.109.2024.03.06.06.07.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 06 Mar 2024 06:07:18 -0800 (PST) Message-ID: <5760021d-9de3-492d-af65-225e61971901@redhat.com> Date: Wed, 6 Mar 2024 15:07:17 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 4/4] GDB: introduce ability to disable frame unwinders To: Eli Zaretskii Cc: gdb-patches@sourceware.org References: <20240306125135.766567-1-blarsen@redhat.com> <20240306125135.766567-5-blarsen@redhat.com> <86zfvbjwui.fsf@gnu.org> From: Guinevere Larsen In-Reply-To: <86zfvbjwui.fsf@gnu.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_BARRACUDACENTRAL,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 06/03/2024 14:47, Eli Zaretskii wrote: >> From: Guinevere Larsen >> Cc: Guinevere Larsen >> Date: Wed, 6 Mar 2024 13:51:35 +0100 >> >> gdb/NEWS | 7 + >> gdb/doc/gdb.texinfo | 24 +++ >> gdb/frame-unwind.c | 161 +++++++++++++++++- >> gdb/frame-unwind.h | 13 ++ >> gdb/testsuite/gdb.base/frame-unwind-disable.c | 21 +++ >> .../gdb.base/frame-unwind-disable.exp | 114 +++++++++++++ >> 6 files changed, 336 insertions(+), 4 deletions(-) >> create mode 100644 gdb/testsuite/gdb.base/frame-unwind-disable.c >> create mode 100644 gdb/testsuite/gdb.base/frame-unwind-disable.exp > Thanks. > >> --- a/gdb/NEWS >> +++ b/gdb/NEWS >> @@ -43,6 +43,13 @@ disable missing-debug-handler LOCUS HANDLER >> maintenance info linux-lwps >> List all LWPs under control of the linux-nat target. >> >> +maintenance frame-unwinder disable [-name] >> +maintenance frame-unwinder enable [-name] >> + Enable or disable frame unwinders. This is only meant to be used when >> + testing unwinders themselves, and you want to ensure that a fallback >> + algorithm won't obscure a regression. GDB is not expected to behave well > ^^ > Two spaces between sentences, please. > >> +@kindex maint frame-unwinder disable >> +@kindex maint frame-unwinder enable >> +@item maint frame-unwinder disable [OPTION] UNWINDER >> +@item maint frame-unwinder enable [OPTION] UNWINDER > OPTION and UNWINDER should be @var{option} and @var{unwinder}, > respectively. > >> +The meaning of the argument @samp{unwinder} depends on the @samp{option} > The correct markup here is @var, not @samp, since these are not > literal symbols, but instead names of parameters that stand for > something else. Likewise elsewhere in the gdb.texinfo part of the > patch. Ah, thanks for explaining! Should I also change the @samp in the table section? > >> +@table @samp >> +@item @code{-all} >> +ignore @samp{unwinder} and disable/enable all unwinders > This should be a complete sentence: begin with a capital letter and > end with a period. > >> +@item @code{-class} >> +@samp{unwinder} is the class on frame unwinders to be disabled or enabled. > ^^ > This should probably be "of"? > >> +The class may include the prefix @code{FRAME_UNWINDER_}, but it is not >> +required. This is the default option. > What do you mean by the last sentence? What is "this" that is the > default option? And what does "default" mean for an option, since an > option is by definition something that doesn't happen by default. option is an optional parameter, and if the user decides to not provide it, the command will work as if the user had provided the -class option. I can see where the confusion came from, but I'm not really sure how to improve the wording. > >> +Disable one or more frame unwinder(s).\n\ >> +Usage: maint frame-unwinder disable [OPTION] UNWINDER\n\ >> +\n\ >> +The meaning of UNWINDER depends on the OPTION given. These are the possibilities:\n\ > ^^ >> +\t-all - UNWINDER is ignored. All available unwinders will be disabled\n\ > ^^ > > Two spaces between sentences in doc strings as well. > >> +The meaning of UNWINDER depends on the OPTION given. These are the possibilities:\n\ >> +\t-all - UNWINDER is ignored. All available unwinders will be enabled\n\ > Likewise here. > > Reviewed-By: Eli Zaretskii > -- Cheers, Guinevere Larsen She/Her/Hers