From: Pedro Alves <pedro@palves.net>
To: Andrew Burgess <andrew.burgess@embecosm.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Make dcache multi-target-safe
Date: Fri, 24 Sep 2021 18:55:23 +0100 [thread overview]
Message-ID: <577b31d1-97f6-c6ca-f82d-dad8bfb54d71@palves.net> (raw)
In-Reply-To: <20210924165447.GD1900093@embecosm.com>
On 2021-09-24 5:54 p.m., Andrew Burgess wrote:
> * Pedro Alves <pedro@palves.net> [2021-09-24 16:50:11 +0100]:
>
>> By inspection, I noticed that this code in dcache.c is not
>> multi-target-aware:
>>
>> /* If this is a different inferior from what we've recorded,
>> flush the cache. */
>>
>> if (inferior_ptid != dcache->ptid)
>>
>> This doesn't take into account that threads of different targets may
>> have the same ptid.
>>
>> Fixed by also storing/comparing the process_stratum_target.
>>
>> Tested on x86-64-linux-gnu, native and gdbserver.
>
> LGTM.
Thanks Andrew. Pushed.
prev parent reply other threads:[~2021-09-24 17:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-24 15:50 Pedro Alves
2021-09-24 16:54 ` Andrew Burgess
2021-09-24 17:55 ` Pedro Alves [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=577b31d1-97f6-c6ca-f82d-dad8bfb54d71@palves.net \
--to=pedro@palves.net \
--cc=andrew.burgess@embecosm.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).