From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 7E2AF3857C5D for ; Fri, 22 Jul 2022 13:41:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7E2AF3857C5D Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 9742A1E222; Fri, 22 Jul 2022 09:41:39 -0400 (EDT) Message-ID: <578979e9-353c-fd92-853a-b78af2afd8ad@simark.ca> Date: Fri, 22 Jul 2022 09:41:38 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] Add a timeout parameter to gdb_do_one_event Content-Language: en-US To: Patrick Monnerat , gdb-patches@sourceware.org References: <20220317130846.162955-1-patrick@monnerat.net> From: Simon Marchi In-Reply-To: <20220317130846.162955-1-patrick@monnerat.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Jul 2022 13:41:41 -0000 On 2022-03-17 09:08, Patrick Monnerat via Gdb-patches wrote: > Since commit b2d8657, having a per-interpreter event/command loop is not > possible anymore. > > As Insight uses a GUI that has its own event loop, gdb and GUI event > loops have then to be "merged" (i.e.: work together). But this is > problematic as gdb_do_one_event is not aware of this alternate event > loop and thus may wait forever. > > The solution is to implement a wait timeout to gdb_do_one_event. This > cannot be done externally as gdb timers are event sources themselves. > > The new parameter defaults to "no timeout": as it is used by Insight > only, there is no need to update calls from the gdb source tree. Sorry for the delay. The patch is fine with me. Pedro and Tom also took a look at previous iterations and I didn't see any disagreement either. I don't remember, do you have push access? Otherwise I can push it for you. Simon