From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-136426-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 29614 invoked by alias); 24 Jan 2017 00:03:22 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 29597 invoked by uid 89); 24 Jan 2017 00:03:21 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-5.1 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=HCc:D*ca, googling
X-HELO: mx1.redhat.com
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 24 Jan 2017 00:03:20 +0000
Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24])	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))	(No client certificate requested)	by mx1.redhat.com (Postfix) with ESMTPS id 8846A3A769D;	Tue, 24 Jan 2017 00:03:20 +0000 (UTC)
Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.phx2.redhat.com [10.5.9.4])	by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id v0O03DQv027322;	Mon, 23 Jan 2017 19:03:19 -0500
Subject: Re: [PATCH 3/5] Make Python inferior-related internal functions return inferior_object*
To: Simon Marchi <simon.marchi@ericsson.com>, gdb-patches@sourceware.org
References: <20170123224004.8893-1-simon.marchi@ericsson.com> <20170123224004.8893-4-simon.marchi@ericsson.com>
Cc: Simon Marchi <simon.marchi@polymtl.ca>
From: Pedro Alves <palves@redhat.com>
Message-ID: <579ee75c-f8dd-d2d4-c3e1-1bf32eac7449@redhat.com>
Date: Tue, 24 Jan 2017 00:03:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0
MIME-Version: 1.0
In-Reply-To: <20170123224004.8893-4-simon.marchi@ericsson.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
X-SW-Source: 2017-01/txt/msg00482.txt.bz2

A quick comment, haven't read the whole series yet:

On 01/23/2017 10:40 PM, Simon Marchi wrote:
> -typedef struct
> +struct inferior_object
>  {
>    PyObject_HEAD

How about switching to:

 struct inferior_object : PyObject
 {

This then avoids the need for casts to PyObject *.

Googling around for "public PyObject", I find several projects
doing that.

Thanks,
Pedro Alves