From: Alan Hayward <Alan.Hayward@arm.com>
To: Luis Machado <Luis.Machado@arm.com>
Cc: "gdb-patches\\@sourceware.org" <gdb-patches@sourceware.org>,
nd <nd@arm.com>
Subject: Re: [PATCH] [Arm] Update the list of recognized m-profile TAG_CPU_ARCH_*
Date: Fri, 25 Mar 2022 18:28:37 +0000 [thread overview]
Message-ID: <57D7ABD4-3935-4080-A1E9-9369690D12CE@arm.com> (raw)
In-Reply-To: <20220323092133.84141-1-luis.machado@arm.com>
> On 23 Mar 2022, at 09:21, Luis Machado via Gdb-patches <gdb-patches@sourceware.org> wrote:
>
> Check 3 additional variants previously not recognized:
>
> - TAG_CPU_ARCH_V7E_M
> - TAG_CPU_ARCH_V8M_BASE
> - TAG_CPU_ARCH_V8M_MAIN
> ---
> gdb/arm-tdep.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/gdb/arm-tdep.c b/gdb/arm-tdep.c
> index 7903069c076..9a10b4d1497 100644
> --- a/gdb/arm-tdep.c
> +++ b/gdb/arm-tdep.c
> @@ -9342,6 +9342,9 @@ arm_gdbarch_init (struct gdbarch_info info, struct gdbarch_list *arches)
> if (!tdesc_has_registers (tdesc)
> && (attr_arch == TAG_CPU_ARCH_V6_M
> || attr_arch == TAG_CPU_ARCH_V6S_M
> + || attr_arch == TAG_CPU_ARCH_V7E_M
> + || attr_arch == TAG_CPU_ARCH_V8M_BASE
> + || attr_arch == TAG_CPU_ARCH_V8M_MAIN
> || attr_arch == TAG_CPU_ARCH_V8_1M_MAIN
> || attr_profile == 'M'))
This looks ok to me.
I double checked to make sure there aren’t any more mprofile defines not being checked.
Alan.
> is_m = true;
> --
> 2.25.1
>
prev parent reply other threads:[~2022-03-25 18:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-23 9:21 Luis Machado
2022-03-25 18:28 ` Alan Hayward [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57D7ABD4-3935-4080-A1E9-9369690D12CE@arm.com \
--to=alan.hayward@arm.com \
--cc=Luis.Machado@arm.com \
--cc=gdb-patches@sourceware.org \
--cc=nd@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).