From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 73933 invoked by alias); 3 Oct 2016 22:27:10 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 73921 invoked by uid 89); 3 Oct 2016 22:27:09 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.5 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=person X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 03 Oct 2016 22:26:59 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 3DFBFC05ACA3; Mon, 3 Oct 2016 22:26:58 +0000 (UTC) Received: from valrhona.uglyboxes.com (ovpn03.gateway.prod.ext.phx2.redhat.com [10.5.9.3]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u93MQvTl025585 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 3 Oct 2016 18:26:57 -0400 Subject: Re: [RFA 2/3] PR gdb/20653 - small cleanup in string_to_explicit_location To: Tom Tromey , gdb-patches@sourceware.org References: <1475531646-18049-1-git-send-email-tom@tromey.com> <1475531646-18049-3-git-send-email-tom@tromey.com> From: Keith Seitz Message-ID: <57F2DB31.50406@redhat.com> Date: Mon, 03 Oct 2016 22:27:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <1475531646-18049-3-git-send-email-tom@tromey.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2016-10/txt/msg00032.txt.bz2 On 10/03/2016 02:54 PM, Tom Tromey wrote: > This bug points out that string_to_explicit_location compares a char* > against '\0'; whereas comparing against NULL is more normal. > > 2016-10-03 Tom Tromey > > PR breakpoints/20653: > * location.c (string_to_explicit_location): Use NULL, not '\0'. While I cannot approve changes to this code, having been the under-caffeinated person who wrote it all, I'd have to say that your patch is correct. Thank you for taking care of this! [And hopefully a maintainer agrees with us. :-)] Keith