From: Bernhard Heckel <bernhard.heckel@intel.com>
To: Yao Qi <qiyaoltc@gmail.com>
Cc: brobecker@adacore.com, gdb-patches@sourceware.org
Subject: Re: [PATCH V4 3/6] Typeprint: Resolve any dynamic target type of a pointer.
Date: Wed, 05 Oct 2016 11:03:00 -0000 [thread overview]
Message-ID: <57F4DE0E.2030505@intel.com> (raw)
In-Reply-To: <861szvayzg.fsf@gmail.com>
On 05/10/2016 12:09, Yao Qi wrote:
> Bernhard Heckel <bernhard.heckel@intel.com> writes:
>
>> +extern "C" {
>> +#include <stddef.h>
>> +}
>> +
> Why do you include stddef.h?
definition of NULL
+ typeof (vla) *ptr = NULL;
>> diff --git a/gdb/typeprint.c b/gdb/typeprint.c
>> index e77513e..e3d84c7 100644
>> --- a/gdb/typeprint.c
>> +++ b/gdb/typeprint.c
>> @@ -485,6 +485,25 @@ whatis_exp (char *exp, int show)
>> printf_filtered (" */\n");
>> }
>>
>> + /* Resolve any dynamic target type, as we might print
>> + additional information about the target.
>> + For example, in Fortran and C we are printing the dimension of the
>> + dynamic array the pointer is pointing to. */
>> + if (TYPE_CODE (type) == TYPE_CODE_PTR
>> + && is_dynamic_type (type) == 1)
> is_dynamic_type returns bool-like value, so don't check it with 1.
> Looks we need to check is_dynamic_type (TYPE_TARGET_TYPE (type)), no?
is_dynamic_type takes care of target types for pointer and reference types.
So, we can keep it.
>
>> + {
>> + CORE_ADDR addr;
>> + if (NULL != TYPE_DATA_LOCATION (TYPE_TARGET_TYPE(type)))
>> + addr = value_address (val);
>> + else
>> + addr = value_as_address (val);
>> +
>> + if (addr != 0
>> + && type_not_associated (type) == 0)
> likewise, !type_not_associated (type)
>
>> + TYPE_TARGET_TYPE (type) = resolve_dynamic_type (TYPE_TARGET_TYPE (type),
>> + NULL, addr);
>> + }
Intel Deutschland GmbH
Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de
Managing Directors: Christin Eisenschmid, Christian Lamprechter
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928
next prev parent reply other threads:[~2016-10-05 11:03 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-07 6:38 [PATCH V4 0/6] Fortran: Resolve target types of pointers Bernhard Heckel
2016-09-07 6:38 ` [PATCH V4 6/6] Fortran: Testsuite, add cyclic pointers Bernhard Heckel
2016-10-13 14:08 ` Yao Qi
2016-09-07 6:38 ` [PATCH V4 1/6] Fortran: Testsuite, fix differences in type naming Bernhard Heckel
2016-09-21 15:57 ` Yao Qi
2016-09-07 6:38 ` [PATCH V4 2/6] Fortran: Resolve dynamic properties of pointer types Bernhard Heckel
2016-10-05 8:44 ` Yao Qi
2016-10-05 9:36 ` Yao Qi
2016-10-05 10:07 ` Bernhard Heckel
2016-09-07 6:38 ` [PATCH V4 5/6] Resolve dynamic target types of pointers Bernhard Heckel
2016-09-07 14:24 ` Eli Zaretskii
2016-10-13 14:07 ` Yao Qi
2016-10-13 14:57 ` Bernhard Heckel
2016-10-17 10:32 ` Yao Qi
2016-10-17 11:25 ` Bernhard Heckel
2016-10-17 12:18 ` Bernhard Heckel
2016-10-20 11:52 ` Bernhard Heckel
2016-10-20 15:33 ` Yao Qi
2016-11-08 7:07 ` Bernhard Heckel
2016-11-08 11:26 ` Yao Qi
2016-11-08 12:27 ` Bernhard Heckel
2016-11-16 12:16 ` Bernhard Heckel
2016-11-21 15:03 ` Bernhard Heckel
2016-09-07 6:38 ` [PATCH V4 4/6] Fortran: Typeprint, fix dangling types Bernhard Heckel
2016-10-13 13:53 ` Yao Qi
2016-09-07 6:38 ` [PATCH V4 3/6] Typeprint: Resolve any dynamic target type of a pointer Bernhard Heckel
2016-10-05 10:10 ` Yao Qi
2016-10-05 11:03 ` Bernhard Heckel [this message]
2016-10-13 13:41 ` Yao Qi
2016-09-14 12:55 ` [PING][PATCH V4 0/6] Fortran: Resolve target types of pointers Bernhard Heckel
2016-09-28 12:45 ` Bernhard Heckel
2016-10-05 6:03 ` [ping 2][PATCH " Bernhard Heckel
2016-09-21 9:49 ` [ping 2] [PATCH " Bernhard Heckel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57F4DE0E.2030505@intel.com \
--to=bernhard.heckel@intel.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=qiyaoltc@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).