From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.loongson.cn (mail.loongson.cn [114.242.206.163]) by sourceware.org (Postfix) with ESMTP id 34ACD386075C for ; Sun, 18 Feb 2024 02:06:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 34ACD386075C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=loongson.cn Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=loongson.cn ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 34ACD386075C Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=114.242.206.163 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708222025; cv=none; b=BLJsmxxsekLsUX9VYIJSguHhRJp9HJnWd5YvCrBW/fTrgAdt+mJlSio4CTWLpcGXPzuNUe6XY0iUHDoaZTPX5zzv4WhPd2PIaveViusfLszR+SbLxIgaxJeubmEKj1OuCH/08M782u3KZzCnAhc3kVX5p2vgFcpFz5BrhHb5cc0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708222025; c=relaxed/simple; bh=FZqachZGBpL2AZE26YA5R+qdTrtcgJMvPCqtpHZs3ow=; h=Subject:To:From:Message-ID:Date:MIME-Version; b=B6/M62x5DHK5LJsZQHTIZsCfBGRyEY491dnvzszANNyfMfcdVElXMHBo1udeTXWDBIkQq/V7BB1WEsZPqxXha+rdvc/0lGeVBsZcXTGsBTH571xd1XE2UJ+soSiS/v/ir1fakZ89jij5vml1gobvFJK3W2Jm2LA8VFoHj9dq9Gc= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from loongson.cn (unknown [113.200.148.30]) by gateway (Coremail) with SMTP id _____8CxWOg6ZtFlBwwOAA--.18212S3; Sun, 18 Feb 2024 10:06:51 +0800 (CST) Received: from [10.130.0.149] (unknown [113.200.148.30]) by localhost.localdomain (Coremail) with SMTP id AQAAf8BxXs04ZtFldVI6AA--.14450S3; Sun, 18 Feb 2024 10:06:49 +0800 (CST) Subject: Re: [PATCH v2] gdb: Modify the output of "info breakpoints" and "delete breakpoints" To: Bruno Larsen , gdb-patches@sourceware.org, Tom Tromey References: <1652951760-10805-1-git-send-email-yangtiezhu@loongson.cn> From: Tiezhu Yang Message-ID: <57a15230-f85e-f763-c5e2-3c5cb90ddc84@loongson.cn> Date: Sun, 18 Feb 2024 10:06:48 +0800 User-Agent: Mozilla/5.0 (X11; Linux mips64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-CM-TRANSID:AQAAf8BxXs04ZtFldVI6AA--.14450S3 X-CM-SenderInfo: p1dqw3xlh2x3gn0dqz5rrqw2lrqou0/ X-Coremail-Antispam: 1Uk129KBj93XoW7CFW7JF1xZrWDJr18Ar1kJFc_yoW8Kw4xpr WfXF1kKr4kZFWUK342gr4UAa45C3sIvry5tw1fG34ak3s8tr4rWw4xGF1jkay7urn3Jryf Kr1xCFn5uF48A3gCm3ZEXasCq-sJn29KB7ZKAUJUUUU5529EdanIXcx71UUUUU7KY7ZEXa sCq-sGcSsGvfJ3Ic02F40EFcxC0VAKzVAqx4xG6I80ebIjqfuFe4nvWSU5nxnvy29KBjDU 0xBIdaVrnRJUUUv0b4IE77IF4wAFF20E14v26r1j6r4UM7CY07I20VC2zVCF04k26cxKx2 IYs7xG6rWj6s0DM7CIcVAFz4kK6r106r15M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48v e4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_JFI_Gr1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI 0_Gr0_Cr1l84ACjcxK6I8E87Iv67AKxVW8JVWxJwA2z4x0Y4vEx4A2jsIEc7CjxVAFwI0_ Gr0_Gr1UM2AIxVAIcxkEcVAq07x20xvEncxIr21l57IF6xkI12xvs2x26I8E6xACxx1l5I 8CrVACY4xI64kE6c02F40Ex7xfMcIj6xIIjxv20xvE14v26r1Y6r17McIj6I8E87Iv67AK xVWUJVW8JwAm72CE4IkC6x0Yz7v_Jr0_Gr1lF7xvr2IY64vIr41lc7I2V7IY0VAS07AlzV AYIcxG8wCF04k20xvY0x0EwIxGrwCFx2IqxVCFs4IE7xkEbVWUJVW8JwC20s026c02F40E 14v26r1j6r18MI8I3I0E7480Y4vE14v26r106r1rMI8E67AF67kF1VAFwI0_Jrv_JF1lIx kGc2Ij64vIr41lIxAIcVC0I7IYx2IY67AKxVWUJVWUCwCI42IY6xIIjxv20xvEc7CjxVAF wI0_Jr0_Gr1lIxAIcVCF04k26cxKx2IYs7xG6r1j6r1xMIIF0xvEx4A2jsIE14v26r1j6r 4UMIIF0xvEx4A2jsIEc7CjxVAFwI0_Jr0_GrUvcSsGvfC2KfnxnUUI43ZEXa7IU8r9N3UU UUU== X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,KAM_DMARC_STATUS,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 05/19/2022 09:08 PM, Bruno Larsen wrote: > > On 5/19/22 06:16, Tiezhu Yang wrote: >> The output of "info breakpoints" includes breakpoint, watchpoint, >> tracepoint and catchpoint, after delete all breakpoints, it should >> show tracepoint and catchpoint in the output of "info breakpoints" >> to report empty list. >> >> It should also change the output of "delete breakpoints" to make it >> clear that watchpoints, tracepoints and catchpoints are also being >> deleted. This is suggested by Bruno Larsen, thank you. >> >> $ make check-gdb TESTS="gdb.base/access-mem-running.exp" >> $ gdb/gdb >> gdb/testsuite/outputs/gdb.base/access-mem-running/access-mem-running >> [...] >> (gdb) break main >> Breakpoint 1 at 0x12000073c: file >> /home/loongson/gdb.git/gdb/testsuite/gdb.base/access-mem-running.c, >> line 32. >> (gdb) watch global_counter >> Hardware watchpoint 2: global_counter >> (gdb) trace maybe_stop_here >> Tracepoint 3 at 0x12000071c: file >> /home/loongson/gdb.git/gdb/testsuite/gdb.base/access-mem-running.c, >> line 27. >> (gdb) catch fork >> Catchpoint 4 (fork) >> (gdb) info breakpoints >> Num Type Disp Enb Address What >> 1 breakpoint keep y 0x000000012000073c in main at >> /home/loongson/gdb.git/gdb/testsuite/gdb.base/access-mem-running.c:32 >> 2 hw watchpoint keep y global_counter >> 3 tracepoint keep y 0x000000012000071c in maybe_stop_here >> at /home/loongson/gdb.git/gdb/testsuite/gdb.base/access-mem-running.c:27 >> not installed on target >> 4 catchpoint keep y fork >> >> Without this patch: >> >> (gdb) delete breakpoints >> Delete all breakpoints? (y or n) y >> (gdb) info breakpoints >> No breakpoints or watchpoints. >> (gdb) info breakpoints 3 >> No breakpoint or watchpoint matching '3'. >> >> With this patch: >> >> (gdb) delete breakpoints >> Delete all breakpoints, watchpoints, tracepoints and catchpoints? (y >> or n) y >> (gdb) info breakpoints >> No breakpoints, watchpoints, tracepoints or catchpoints. >> (gdb) info breakpoints 3 >> No breakpoint, watchpoint, tracepoint or catchpoint matching '3'. >> > > Hey Tiezhu, > > Thanks for this change, I'm fine with this patch. However, I can't > approve patches to be pushed. Let's hope a maintainer shows up soon :-) Hi, Is it necessary to rebase and update this patch? Should I drop it or send a new version? Thanks, Tiezhu