From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60061.outbound.protection.outlook.com [40.107.6.61]) by sourceware.org (Postfix) with ESMTPS id 912683858C56 for ; Tue, 21 Jun 2022 11:13:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 912683858C56 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=iPVwcKyplvXPwKvl+poLIE5dl2JMIucL0q06m1dw2fLvuAWBGeKPp3ngQ8q8wlYK8FyX04WEYNXsUIUR+X/FjbuMlEBOOT8/mBuxa8LHkErTT6pZ2uf/3tu8AkoRI8cXF2z1kHT0PPFlx86GAkDfXBG4diyZjg+Clm+N/y/PKGV/Wy9otLDAidTddvEKFAI/JkO5Y9zL1qBetj6UEXg1L4fzObLiPx20y2bmRl6etRIncOlLiFGOfLCkCvVCXnbKLqCRSv+7x1Lwnuglpiu0+R0BAXd3sK512bw5aZXO7DXabvzs06nsP0JLZGo2IOPR526psCvACQmLQhynGAQd0g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=25k2Wwo1k/P0uZNJ8sFz3MGmFbZSMLdLV5ITZkdfp4U=; b=GFaO9mytn2XcO5F0Vl2umnYGYStpNNLhnDTwNyazUpCjRLaib2JmR5W1t7rb/qkkAEy0fvAmfEpOADCtmY/KdhhZ8VnVoIQZIWGkXsac/nmmzt4Wa0OKRtPiyYORMTMaUrlMOwhEZ+/hbEgF3tViHV/ZpdtGmfa4Cai9ui3fOpmzHIb8VslyNLQ5AqIOi3CBokyIRMn4KmyfSYjPNBxDV1djemwlpAxWUWsHfmk6raIuqdztqXHxlughBBJoBWywuxE3Xty4a9Kx4xCiMEx5aEd0MCSk/31KyO6CEoB7c5WvPfeShohS0GChmDEGV2kDcdReD4nWEIKdHTj0Xofxmw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=sourceware.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) Received: from DB6P18901CA0012.EURP189.PROD.OUTLOOK.COM (2603:10a6:4:16::22) by AM8PR08MB5650.eurprd08.prod.outlook.com (2603:10a6:20b:1d3::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5353.14; Tue, 21 Jun 2022 11:13:01 +0000 Received: from DBAEUR03FT028.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:16:cafe::27) by DB6P18901CA0012.outlook.office365.com (2603:10a6:4:16::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5353.14 via Frontend Transport; Tue, 21 Jun 2022 11:13:01 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT028.mail.protection.outlook.com (100.127.142.236) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5353.14 via Frontend Transport; Tue, 21 Jun 2022 11:13:01 +0000 Received: ("Tessian outbound 1766a3bff204:v120"); Tue, 21 Jun 2022 11:13:01 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 4995c39feb1ee2fa X-CR-MTA-TID: 64aa7808 Received: from f1baef1c1db8.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 256D3D20-22EB-4CFC-B936-A24FC1B84612.1; Tue, 21 Jun 2022 11:12:53 +0000 Received: from EUR01-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id f1baef1c1db8.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 21 Jun 2022 11:12:53 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RMTnCB7PJIjaP3iWKF1/hrUbM9dGZpdvHU0emcYjeO5AdFGsvcn0GC+TbD8RfLeHXWusQfhd1wHn1w5fcwTdq5fBIezkAzwxk66/HHIgivcwSvt7GKNwNJMUm4LGsQPmJOuRvV/Yih5ODb5sosBtb9mB7Ct0QMYF9gUFI1WFYi7b/mb0pN5haiG+sJlFqumHO5gnPWtQfQa5IqjqEgSLSHlarDsrTks8y1b8p+2AZNrabB947kdTPw68RjiiOjOpOdbbPH6U00IZ+NRoCC4iJj/anEh1PBhd2wOB0OlKYz6Z1iYuRsX4YmhaayzYKkzEW5Ofw+ygL2zszvPXTj+JKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=25k2Wwo1k/P0uZNJ8sFz3MGmFbZSMLdLV5ITZkdfp4U=; b=D4FjgUaZjgQz+ZP2iMLyvtdMdajAeQh5MSmoaWuBNQPAO1j3316VHPd+47gxG5mWDStoz++PhL4HRWywa/ebqHd8MiVnAqnkXmfJr4Lw6CTptYJ4wxepXuiLF+9z2K2lADdNTkDTh5NDkeiubRAFyRHGvhLZ/YeeRmlwsFbu++WdmLqIEKclawKC1Ps9TnjPv9J3NSZTdPGQmiJ5ifustZH4Odyy8+aQTtet5q/jxpM0by2hLs43Dx498c/zi45YT5/3scQHFWuniURV1Wsuqfx8QlMgcDp9WJq6eIkqCSmbfQxmOhuLmzNMizUP4HJr/ytMBepVhzpvB08UNraECQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) by AM5PR0801MB1682.eurprd08.prod.outlook.com (2603:10a6:203:2e::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5353.14; Tue, 21 Jun 2022 11:12:48 +0000 Received: from VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::1cda:8ca1:6353:572c]) by VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::1cda:8ca1:6353:572c%4]) with mapi id 15.20.5353.022; Tue, 21 Jun 2022 11:12:48 +0000 Message-ID: <57b8973e-bf15-62c0-5e55-93efb310395e@arm.com> Date: Tue, 21 Jun 2022 12:12:45 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: gdb/arm: Update the value of active sp when base sp changes Content-Language: en-US To: Yvan Roux , gdb-patches@sourceware.org Cc: Torbjorn SVENSSON References: <20220617130426.GB5800@gnbcxd0114.gnb.st.com> From: Luis Machado In-Reply-To: <20220617130426.GB5800@gnbcxd0114.gnb.st.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO2P265CA0339.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:d::15) To VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 9a5578fa-7e10-4122-169c-08da53770114 X-MS-TrafficTypeDiagnostic: AM5PR0801MB1682:EE_|DBAEUR03FT028:EE_|AM8PR08MB5650:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: Ni1BS93h1aoKIP2aaZkDGJbfiVthVt0oZtl0phlAk8l1kEPVIp2ZIC2dMItvVn77Ok8fWP59QK5kRZmGXiZXjXBRAXOCoOGM4sd/peSidA/GVbepz2t5UTqildFp/VcQG+2kUg2UITI3J0rEWk1/Ty41/kQyh2p8Oob9i1Cj2Qezl1MmHsCA49+ZQjqhSYuxHHfGbYfeG4/0eT71fXKl/SFSL1DUEiDbAbDz4xWmpfWRKngkuE/oAI1Tkf8GBuTQ/GZt+w/XtNDdBy6gaJcTeKqksmnBeP6k/51y3iIw6AFtolXqEUzy2/Au/zCxGCriQms8izxCI2gHrgKUeJm2Q4buqQ5n6LHGOt4568/p8PuMkLdlvp1h1BMKoDks71nLT83FLODIhxuL22+dmOsxq6Tv/L7PA/FQFCjeCVFicjwydeNyQyn3sCmlq3RXId/2mEKcdWi0j+gZ5OIPHyw0BhkZ5e0m0Do7vyV3Spv0nxP87r5CBXgoLpJu8ZdNZni0AGYIiKu4BXvPtdoU2g0oHqn0k0UAqZE7ho5efDC+rDrt/QzE2uA55caeJGZyFr+boEbrFrJDhCjj1lOgm5QKWrldZR0uFKFnpZ05b0TWyMsvL4l8mGWCFQ3cuV20GcF202upN04Il9iO8DsElNbqUg7s2S3aIU1uGyvlAtmA4cFfdypXfpNx8DYBx3fxDKzhOgH+jIYIN9rBThYJRK9qtXAOL92s/uE34rVZawE9BhA= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR08MB3919.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(4636009)(136003)(366004)(39860400002)(396003)(376002)(346002)(86362001)(26005)(6486002)(6666004)(66476007)(6512007)(66574015)(31696002)(83380400001)(38100700002)(6506007)(41300700001)(2616005)(186003)(53546011)(66556008)(31686004)(8936002)(5660300002)(15650500001)(316002)(36756003)(44832011)(8676002)(4326008)(2906002)(478600001)(66946007)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0801MB1682 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT028.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: f417f44c-9484-4328-604a-08da5376f94b X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: JKhlk/lFX252WhckPsLMI/1fvi7H2l/cXZCNsT0BfzzYLRyZrgu5nx2bgZDpn8mEyOnaXs1KIMZ7Q9dgXzMGJBVUe75hvVR2xFnlhGk0Yzgd3RhSktzzyC7zfaxG/m+jRuIWgETeGgsng9SONJEeyM1PRvYNvGLRRJKIERRDU3WRJNsNio6uoiAyisYLFGSq5oojs8HzWqZzwchDnxbEvoU/4rwdkoltPzruf8dyRJQeWT6Tv2iDpTthmcuwdv88QgCRjxtZVCywXh/rRoqoRhxk1vtVad6e1xZRmqGJn3Hw1uE4uJwHei93FCN+BYTRm5gF9kHC0yOp81yC5Hsqva/Opg6LfEOvCa5b+NwpJq97MB3jdvz2eh4BWdvVmowbNmiG3stDc6yvFMM3l/dpOlAXFFta4xBtE6+z96aziAOIInQfIWSa8NtXuaoNG3VuCERWUvk3pnfAKEe67bFoZ1z/bx6KBBv0jmYF6n0NwqAYZrPHDEQw2KG42KTYqSXYwlokRmXO7lZpcVVqblEYbUQImTTiIWhIn2OqZ4iY7rfTfc8e7mt7sgUJPQZ0DAuw5FwciPUhkSRCmRVmREBEkEoSOO3o3BUv+RQHl4sKnrmKQxp6IFDXBUbfgE/v9qSbZEIEWKg0it0xodjPLqrOmScmfaAx1y9scny4fURXae4qtZ53Wwo6Zdag05fCgocFQqKgnaJHkYiPIlIAvnxVLKxzgMWHcU84yD2fgDQxNkkW9Sd1lEQs5iOcLvH43s4h X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(13230016)(4636009)(39860400002)(396003)(136003)(346002)(376002)(36840700001)(46966006)(40470700004)(6512007)(6506007)(186003)(356005)(82740400003)(31696002)(86362001)(2906002)(26005)(41300700001)(40460700003)(47076005)(336012)(53546011)(81166007)(83380400001)(2616005)(31686004)(478600001)(6486002)(66574015)(5660300002)(8936002)(82310400005)(40480700001)(15650500001)(44832011)(6666004)(36756003)(8676002)(4326008)(70206006)(36860700001)(316002)(70586007)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jun 2022 11:13:01.0653 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9a5578fa-7e10-4122-169c-08da53770114 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT028.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR08MB5650 X-Spam-Status: No, score=-12.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, FORGED_SPF_HELO, GIT_PATCH_0, KAM_DMARC_NONE, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Jun 2022 11:13:05 -0000 Hi, On 6/17/22 14:04, Yvan Roux wrote: > Hi, > > For Arm Cortex-M33 with security extensions, there are 4 different > stacks pointers (msp_s, msp_ns, psp_s, psp_ns). > When plain "sp" is updated during unwinding of the stack, the active > stack pointer of the 4 stack pointers needs to be kept in sync. > > Signed-off-by: Torbjörn SVENSSON > Signed-off-by: Yvan Roux > --- > gdb/arm-tdep.c | 16 +++++++++++----- > 1 file changed, 11 insertions(+), 5 deletions(-) > > diff --git a/gdb/arm-tdep.c b/gdb/arm-tdep.c > index 0c907482036..96d70d40b28 100644 > --- a/gdb/arm-tdep.c > +++ b/gdb/arm-tdep.c > @@ -923,6 +923,7 @@ thumb_analyze_prologue (struct gdbarch *gdbarch, > CORE_ADDR start, CORE_ADDR limit, > struct arm_prologue_cache *cache) > { > + arm_gdbarch_tdep *tdep = (arm_gdbarch_tdep *) gdbarch_tdep (gdbarch); > enum bfd_endian byte_order = gdbarch_byte_order (gdbarch); > enum bfd_endian byte_order_for_code = gdbarch_byte_order_for_code (gdbarch); > int i; > @@ -1398,9 +1399,6 @@ thumb_analyze_prologue (struct gdbarch *gdbarch, > unrecognized_pc = start; > } > > - arm_gdbarch_tdep *tdep > - = (arm_gdbarch_tdep *) gdbarch_tdep (gdbarch); > - > /* Make sure we are dealing with a target that supports ARMv8.1-m > PACBTI. */ > if (cache != nullptr && tdep->have_pacbti > @@ -1460,7 +1458,11 @@ thumb_analyze_prologue (struct gdbarch *gdbarch, > > for (i = 0; i < gdbarch_num_regs (gdbarch); i++) > if (stack.find_reg (gdbarch, i, &offset)) > - cache->saved_regs[i].set_addr (offset); > + { > + cache->saved_regs[i].set_addr (offset); > + if (i == ARM_SP_REGNUM) > + arm_cache_set_active_sp_value(cache, tdep, offset); > + } > > return unrecognized_pc; > } > @@ -2087,7 +2089,11 @@ arm_analyze_prologue (struct gdbarch *gdbarch, > > for (regno = 0; regno < ARM_FPS_REGNUM; regno++) > if (stack.find_reg (gdbarch, regno, &offset)) > - cache->saved_regs[regno].set_addr (offset); > + { > + cache->saved_regs[regno].set_addr (offset); > + if (regno == ARM_SP_REGNUM) > + arm_cache_set_active_sp_value(cache, tdep, offset); > + } > } > > arm_debug_printf ("Prologue scan stopped at %s", Thanks. This is OK.