Re: [PATCH] [gdb/build] Fix build on postmarketos

[Tom de Vries <tdevries@suse.de>]

On 3/14/24 13:43, Tom Tromey wrote:
>>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:
> 
> Tom> I tried building gdbserver on postmarketos (which is based on alpine linux,
> Tom> which uses musl libc), and ran into:
> Tom> ...
> Tom> gdbserver/linux-low.cc: In lambda function:
> Tom> gdbserver/linux-low.cc:1907:41: error: \
> Tom>   'W_EXITCODE' was not declared in this scope
> Tom>  1907 |               mark_lwp_dead (leader_lp, W_EXITCODE (0, 0), true);
> Tom>       |                                         ^~~~~~~~~~
> Tom> ...
> 
> Tom> The macro W_EXITCODE is not defined in gdbsupport/gdb_wait.h, but WSETEXIT is:
> Tom> ...
> Tom>  /* These are not defined in POSIX, but are used by our programs.  */
> 
> Tom>  #ifndef WSETEXIT
> Tom>  # ifdef W_EXITCODE
> Tom>  #define WSETEXIT(w,status) ((w) = W_EXITCODE(status,0))
> Tom>  # else
> Tom>  #define WSETEXIT(w,status) ((w) = (0 | ((status) << 8)))
> Tom>  # endif
> Tom>  #endif
> Tom> ...
> 
> I think it'd be better to change this to define W_EXITCODE.
> WSETEXIT isn't used in the tree at all AFAICT.

Thanks for the review.

Fine by me, I've submitted a v2 here ( 
https://sourceware.org/pipermail/gdb-patches/2024-March/207288.html ).

Thanks,
- Tom