From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id D050B3858D33 for ; Mon, 28 Aug 2023 16:01:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D050B3858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=polymtl.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=polymtl.ca Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 37SG1e1p017947 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 28 Aug 2023 12:01:44 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 37SG1e1p017947 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=polymtl.ca; s=default; t=1693238505; bh=8GeHCn0gEyUeeG91GDFd4f6HooOqxTTcVcido52HkR4=; h=Date:Subject:To:References:From:In-Reply-To:From; b=Rj/UUWXe5b20qFwZCq4VMQduLnC0lKXt5btPrcY/ZhgK0Tz9ICg43WNkFkbcnFw4O SVahVKAIGJ0O8SE/lzJuXrsVXDb+aZsjlo5MQcRljWGEA7DUYAeGlWGdsKg84VZfX+ 1CRZf7s+QnkGVZg2RDKqata/VqmsEB2E8gUHLVNw= Received: from [10.0.0.170] (modemcable238.237-201-24.mc.videotron.ca [24.201.237.238]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id E3E0E1E092; Mon, 28 Aug 2023 12:01:39 -0400 (EDT) Message-ID: <57deb7cd-46ff-4e39-a3d3-f6ffcb132d8e@polymtl.ca> Date: Mon, 28 Aug 2023 12:01:39 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6a 06/15] gdb: Update x86 FreeBSD architectures to support XSAVE layouts. Content-Language: fr To: John Baldwin , gdb-patches@sourceware.org References: <20230714155151.21723-1-jhb@FreeBSD.org> <20230714155151.21723-7-jhb@FreeBSD.org> From: Simon Marchi In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Mon, 28 Aug 2023 16:01:40 +0000 X-Spam-Status: No, score=-3031.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 7/28/23 17:23, John Baldwin wrote: > Refactor i386fbsd_core_read_xcr0 to fetch and return a corresponding > x86_xsave_layout as well as xcr0 using the size of an existing > NT_X86_XSTATE core dump to determine the offsets via > i387_guess_xsave_layout. Use this to add an implementation of > gdbarch_core_xfer_x86_xsave_layout. > > Use tdep->xsave_layout.sizeof_xsave as the size of the XSTATE register > set and only fetch/store the register set if this size is non-zero. Approved-By: Simon Marchi Simon