public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Mike Frysinger <vapier@gentoo.org>
To: gdb-patches@sourceware.org
Cc: Nick Clifton <nickc@redhat.com>
Subject: Re: MSP430 SIM: Add support for hardware multiply
Date: Sat, 02 Aug 2014 14:54:00 -0000	[thread overview]
Message-ID: <5804568.hLA7fg3VQR@vapier> (raw)
In-Reply-To: <87zjislnam.fsf@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 851 bytes --]

On Thu 08 May 2014 08:52:49 Nick Clifton wrote:
>   I am applying the attached patch to add support for simulating the
>   hardware multiply feature found on some MSP430 MCUs.

any reason for the compression ?  its size doesn't seem to justify it at all.

> sim/msp430/ChangeLog
> 2014-05-08  Nick Clifton  <nickc@redhat.com>
> 
> 	* msp430-sim.c (sim_open): Do not allocate memory over the
> 	hardware multiply registers.
> 	(get_op): Add support for reads from the hardware multiply
> 	registers.
> 	(put_op): Add support for writes to the hardware multiply
> 	registers.
> 	(msp430_step_once): Add support for the RETI instruction used by
> 	the CPUX architecture.

the global static vars really look like they should be part of the cpu or sim 
state and not just global variables.  otherwise you can't easily reset them ?
-mike

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

  reply	other threads:[~2014-08-02 14:54 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-08  7:53 Nick Clifton
2014-08-02 14:54 ` Mike Frysinger [this message]
2014-08-19  9:58   ` Nicholas Clifton
2014-08-19 10:36   ` Nicholas Clifton
2014-08-20  9:24     ` Mike Frysinger
2015-12-25  0:22 ` Mike Frysinger
2016-01-05 16:43   ` Nick Clifton
2016-01-05 19:16     ` Mike Frysinger
2016-01-07 10:53       ` Nick Clifton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5804568.hLA7fg3VQR@vapier \
    --to=vapier@gentoo.org \
    --cc=gdb-patches@sourceware.org \
    --cc=nickc@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).