From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id DD856385C8B1 for ; Thu, 5 Oct 2023 17:23:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org DD856385C8B1 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=polymtl.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=polymtl.ca Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 395HNIT3011609 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 5 Oct 2023 13:23:23 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 395HNIT3011609 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=polymtl.ca; s=default; t=1696526603; bh=JH+8xPZgHt/PJ22ATtW6qlJ6gR0HbDiGM9u2fS6qzx8=; h=Date:Subject:To:References:From:In-Reply-To:From; b=jviPmnZPXm6u2Tls3B2NsCr38Mf8TQTnTQj/lMZFWCnNF1lbc7MT7S4Mf6RlDFlCC uKEqpiE59nsBYlA9/HafjycXWfg4F0EJ2MjlZyGxPu5L8MTFomrlN8AxXjd5+TyKwz mx97gYCoD9yQSJbIWjcgpFMQ4lXqvBnWlMkjrKMU= Received: from [172.16.0.192] (192-222-143-198.qc.cable.ebox.net [192.222.143.198]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 648BE1E092; Thu, 5 Oct 2023 13:23:18 -0400 (EDT) Message-ID: <5833a14f-41cf-4e30-8c89-12572bb0a765@polymtl.ca> Date: Thu, 5 Oct 2023 13:23:18 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/8] Split new_objfile observable Content-Language: fr To: Tom Tromey , Simon Marchi via Gdb-patches References: <20231004022305.298534-1-simon.marchi@polymtl.ca> <87sf6pvxfo.fsf@tromey.com> From: Simon Marchi In-Reply-To: <87sf6pvxfo.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Thu, 5 Oct 2023 17:23:18 +0000 X-Spam-Status: No, score=-3031.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 10/5/23 12:36, Tom Tromey wrote: >>>>>> "Simon" == Simon Marchi via Gdb-patches writes: > > Simon> The goal of this series is to split the new_objfile observable in two. > Simon> It currently serves two purposes: > > Simon> - if called with a non-nullptr objfile, it means a new objfile was > Simon> added to the current program space > Simon> - if called with a nullptr objfile, it means all objfiles were removed > Simon> from the current program space > > Simon> Introduce a new "all_objfiles_removed" observable for the second > Simon> purpose. > > This all seems fine to me. Thank you. > Approved-By: Tom Tromey > > Tom Thanks, pushed. Simon