From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 115976 invoked by alias); 26 Nov 2018 21:31:08 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 115805 invoked by uid 89); 26 Nov 2018 21:30:53 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=2018-10-31, opinions, 20181031, Hx-languages-length:664 X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 26 Nov 2018 21:30:52 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id wAQLUjBM028807 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 26 Nov 2018 16:30:50 -0500 Received: by simark.ca (Postfix, from userid 112) id 9704F1E93F; Mon, 26 Nov 2018 16:30:45 -0500 (EST) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id AAF881E48F; Mon, 26 Nov 2018 16:30:44 -0500 (EST) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Mon, 26 Nov 2018 21:31:00 -0000 From: Simon Marchi To: Tom de Vries Cc: Simon Marchi , gdb-patches@sourceware.org, Phil Muldoon , Tom Tromey Subject: Re: [PATCH][gdb/python] Add interface to access minimal_symbols In-Reply-To: <211c4746-389a-93b7-faf9-c8f9b6245541@suse.de> References: <20181004211115.GA31056@delia> <39c4336d-c749-6f79-5a29-0b764fc4935e@ericsson.com> <211c4746-389a-93b7-faf9-c8f9b6245541@suse.de> Message-ID: <583cbe68c00a387d0664f918f078e9a8@polymtl.ca> X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.3.6 X-IsSubscribed: yes X-SW-Source: 2018-11/txt/msg00449.txt.bz2 On 2018-10-31 12:59, Tom de Vries wrote: > AFAIU, the purpose of repr is to print a unique representation, and > distinct symbols can have the same name, so I went for: > ... > > ... > for local symbols, dropping the filename=%s part for local symbols. Thanks, that make sense. The patch looks good to me, but since adding some new Python API is kind of a big deal (we are stuck with it after), I'd really like if Phil and/or Tom could give their opinions. Especially since I remember Phil mentioning he had other plans for minimal symbols... Simon