From: Simon Marchi <simon.marchi@polymtl.ca>
To: Michael Weghorn <m.weghorn@posteo.de>, gdb-patches@sourceware.org
Subject: Re: [PATCH v3] gdb: Do autoload before notifying Python side in new_objfile event
Date: Fri, 23 Apr 2021 06:48:41 -0400 [thread overview]
Message-ID: <583d657e-0a87-2066-c64b-7b982e642593@polymtl.ca> (raw)
In-Reply-To: <0c435306-3368-d707-fffe-f7e03a93fb26@posteo.de>
> What do you think about this?
>
> /* Observer has been inserted at the end of the vector, so it will be after
> any potential dependencies attached earlier.
> If the observer has a token, it means that other observers can specify
> a dependency on it, so sorting is necessary to ensure those will be
> after the newly inserted observer afterwards. */
> if (t != nullptr)
> {
> sort_elements ();
> }
That's perfect, thanks.
Simon
next prev parent reply other threads:[~2021-04-23 10:48 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-10 15:40 [PATCH] gdb: Change init order so pretty printers are set " Michael Weghorn
2021-02-11 9:42 ` Andrew Burgess
2021-02-11 11:23 ` Michael Weghorn
2021-03-02 7:18 ` Michael Weghorn
2021-03-23 18:55 ` Simon Marchi
2021-03-24 9:45 ` Andrew Burgess
2021-03-24 13:51 ` Simon Marchi
2021-03-26 8:33 ` Michael Weghorn
2021-02-11 11:22 ` [PATCH v2] " Michael Weghorn
2021-03-23 8:01 ` [PING] " Michael Weghorn
2021-03-26 8:29 ` [PATCH v3] gdb: Do autoload before notifying Python side " Michael Weghorn
2021-04-12 13:37 ` [PING] " Michael Weghorn
2021-04-20 11:38 ` [PING 2] " Michael Weghorn
2021-04-20 21:57 ` Simon Marchi
2021-04-22 15:46 ` Michael Weghorn
2021-04-22 16:06 ` Simon Marchi
2021-04-23 6:41 ` Michael Weghorn
2021-04-23 10:48 ` Simon Marchi [this message]
2021-04-22 15:44 ` [PATCH v4 0/2] Make sure autoload happens " Michael Weghorn
2021-04-22 15:44 ` [PATCH v4 1/2] gdbsupport: Allow to specify dependencies between observers Michael Weghorn
2021-04-22 15:44 ` [PATCH v4 2/2] gdb: Do autoload before notifying Python side in new_objfile event Michael Weghorn
2021-04-25 1:46 ` [PATCH v4 0/2] Make sure autoload happens " Simon Marchi
2021-04-26 8:18 ` Michael Weghorn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=583d657e-0a87-2066-c64b-7b982e642593@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=gdb-patches@sourceware.org \
--cc=m.weghorn@posteo.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).