From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 4487C393A425 for ; Fri, 23 Apr 2021 10:48:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 4487C393A425 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 13NAmgCr018183 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 23 Apr 2021 06:48:47 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 13NAmgCr018183 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 39CC61E789; Fri, 23 Apr 2021 06:48:42 -0400 (EDT) Subject: Re: [PATCH v3] gdb: Do autoload before notifying Python side in new_objfile event To: Michael Weghorn , gdb-patches@sourceware.org References: <20210210154053.82927-1-m.weghorn@posteo.de> <20210326082934.2522904-1-m.weghorn@posteo.de> <6574953b-c91a-3764-6b9f-b9e0923fd1ac@polymtl.ca> <8e33b994-44fd-e58a-1309-1c0fb954a900@posteo.de> <2e5a3c5f-361d-08b6-3224-660d6abb6687@polymtl.ca> <0c435306-3368-d707-fffe-f7e03a93fb26@posteo.de> From: Simon Marchi Message-ID: <583d657e-0a87-2066-c64b-7b982e642593@polymtl.ca> Date: Fri, 23 Apr 2021 06:48:41 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <0c435306-3368-d707-fffe-f7e03a93fb26@posteo.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Fri, 23 Apr 2021 10:48:42 +0000 X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Apr 2021 10:48:57 -0000 > What do you think about this? > > /* Observer has been inserted at the end of the vector, so it will be after > any potential dependencies attached earlier. > If the observer has a token, it means that other observers can specify > a dependency on it, so sorting is necessary to ensure those will be > after the newly inserted observer afterwards. */ > if (t != nullptr) > { > sort_elements (); > } That's perfect, thanks. Simon