public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Tsukasa OI <research_trasio@irq.a4lg.com>
To: Tsukasa OI <research_trasio@irq.a4lg.com>,
	Andrew Burgess <aburgess@redhat.com>,
	Tom de Vries <tdevries@suse.de>
Cc: gdb-patches@sourceware.org
Subject: [PATCH 1/1] sim/ppc: Fix core_find_mapping diagnostics
Date: Wed, 12 Oct 2022 12:38:59 +0000	[thread overview]
Message-ID: <5894ec3b0f77b7fe60b8fe7376780f0874267e15.1665578330.git.research_trasio@irq.a4lg.com> (raw)
In-Reply-To: <cover.1665578330.git.research_trasio@irq.a4lg.com>

Because "%p" is the pointer conversion specifier to print a pointer in an
implementation-defined manner, the result with format string containing
"0x%p" can be strange.  For instance, core_map_find_mapping prints error
containing "0x0x...." (processor is not NULL) or "0x(null)" (processor is
NULL) on glibc.

This commit replaces "0x%p" with "%p" to prevent unpredictable behavior.
---
 sim/ppc/corefile.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sim/ppc/corefile.c b/sim/ppc/corefile.c
index b2faef58c5b..ee4e2cf733e 100644
--- a/sim/ppc/corefile.c
+++ b/sim/ppc/corefile.c
@@ -292,7 +292,7 @@ core_map_find_mapping(core_map *map,
     mapping = mapping->next;
   }
   if (abort)
-    error("core_find_mapping() - access to unmaped address, attach a default map to handle this - addr=0x%x nr_bytes=0x%x processor=0x%p cia=0x%x\n",
+    error("core_find_mapping() - access to unmaped address, attach a default map to handle this - addr=0x%x nr_bytes=0x%x processor=%p cia=0x%x\n",
 	  addr, nr_bytes, (void *) processor, cia);
   return NULL;
 }
-- 
2.34.1


  reply	other threads:[~2022-10-12 12:39 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-25  8:44 [PATCH 0/7] sim, sim/ARCH: Add ATTRIBUTE_PRINTF Tsukasa OI
2022-09-25  8:44 ` [PATCH 1/7] sim: " Tsukasa OI
2022-09-25  8:44 ` [PATCH 2/7] sim/cris: " Tsukasa OI
2022-09-25  8:44 ` [PATCH 3/7] sim/erc32: " Tsukasa OI
2022-09-25  8:44 ` [PATCH 4/7] sim/m32c: " Tsukasa OI
2022-09-25  8:44 ` [PATCH 5/7] sim/m68hc11: " Tsukasa OI
2022-09-25  8:44 ` [PATCH 6/7] sim/ppc: " Tsukasa OI
2022-10-05 10:57   ` Andrew Burgess
2022-10-06  5:32     ` Tsukasa OI
2022-09-25  8:44 ` [PATCH 7/7] sim/rl78: " Tsukasa OI
2022-10-06  6:36 ` [PATCH v2 0/7] sim, sim/ARCH: " Tsukasa OI
2022-10-06  6:36   ` [PATCH v2 1/7] sim: " Tsukasa OI
2022-10-11 14:24     ` Andrew Burgess
2022-10-06  6:36   ` [PATCH v2 2/7] sim/cris: " Tsukasa OI
2022-10-06  6:36   ` [PATCH v2 3/7] sim/erc32: " Tsukasa OI
2022-10-06  6:36   ` [PATCH v2 4/7] sim/m32c: " Tsukasa OI
2022-10-06  6:36   ` [PATCH v2 5/7] sim/m68hc11: " Tsukasa OI
2022-10-11 14:25     ` Andrew Burgess
2022-10-06  6:36   ` [PATCH v2 6/7] sim/ppc: " Tsukasa OI
2022-10-11 14:27     ` Andrew Burgess
2022-10-12  8:29       ` Jan-Benedict Glaw
2022-10-12  9:39         ` Andrew Burgess
2022-10-12 10:36           ` Jan-Benedict Glaw
2022-10-12 12:15             ` Jan-Benedict Glaw
2022-10-12 12:50             ` Jan-Benedict Glaw
2022-10-12 13:16               ` Tsukasa OI
2022-10-12 12:38           ` [PATCH 0/1] sim/ppc: Fix erroneous error calls (supplement) Tsukasa OI
2022-10-12 12:38             ` Tsukasa OI [this message]
2022-10-12 13:50               ` [PATCH 1/1] sim/ppc: Fix core_find_mapping diagnostics Andrew Burgess
2022-10-23 12:46           ` [PATCH v2 6/7] sim/ppc: Add ATTRIBUTE_PRINTF Mike Frysinger
2022-10-06  6:36   ` [PATCH v2 7/7] sim/rl78: " Tsukasa OI
2022-10-11 14:23   ` [PATCH v2 0/7] sim, sim/ARCH: " Andrew Burgess

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5894ec3b0f77b7fe60b8fe7376780f0874267e15.1665578330.git.research_trasio@irq.a4lg.com \
    --to=research_trasio@irq.a4lg.com \
    --cc=aburgess@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=tdevries@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).