From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mailsec208.isp.belgacom.be (mailsec208.isp.belgacom.be [195.238.22.104]) by sourceware.org (Postfix) with ESMTPS id 9A02E3858D33 for ; Sun, 20 Nov 2022 23:46:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 9A02E3858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=skynet.be Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=skynet.be DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=skynet.be; i=@skynet.be; q=dns/txt; s=rmail; t=1668988007; x=1700524007; h=message-id:subject:from:to:date:in-reply-to:references: mime-version:content-transfer-encoding; bh=/Bcr/xrFtUt6AcAUbCPr2zswt28lbSKmLn8U/6j2Auw=; b=HYLFxSx8RovKKpYOOaesLVomT4b8+Zcelvfax9Ev1PNt7B+ZztrrB83k 5MajLmNxE+jqkvxt3XwW6kplXKzKwudZew/tcCsSCpG3PugKYirN7O99K A2xLQ/d4TsVuEbyLXPytSoYdNRAHCcFbSfmdNkDjXtpADrTCQmYVafKch A=; X-ExtLoop: 1 X-IPAS-Result: =?us-ascii?q?A2BrAQDMu3pj/1uGgG0NTYEJCYFGgzGBWIROkRoDkVyLV?= =?us-ascii?q?YF+DwEBAQEBAQEBAQk5CwQBAYUAAwIChQImNgcOAQIEAQEBAQMCAwEBAQEBA?= =?us-ascii?q?QMBAQYBAQEBAQEGBAGBG4UvOYJCIoN9AQEBAyMPAVYJAg0BCgICJgICVwYBg?= =?us-ascii?q?xCDNZcqmx16gTIaZ4NQAYEgmmWBYQaBFCyBZocag2CEMDeBVUSECAcwPoJiA?= =?us-ascii?q?4U2gmcEl10cNwMZKx1AAwttCkobWA4JHxwOFw0FBhIDIGwFCjcPKC9nKxwbB?= =?us-ascii?q?4EMKigVAwQEAwIGEwMiAg0pMRQEKRMNKydvCQIDIWUFAwMEKCwDCSEfBxYRJ?= =?us-ascii?q?jwHVjoBBAMCDyA4BgMJAwIiVXUuERUFAwsVJQgFSwQIOQUGUxICChEDEg8GJ?= =?us-ascii?q?kUOSD45FgYndA4OFANegWkENYFxCplvghY0aQwWAnNSCIEEkkyvXjQHg2uBR?= =?us-ascii?q?wYMiXSVBzKDeJMgA5F7lzQggiuKeJo1gWkNggFtYBOCR1KOVBYViE+FS3Q7A?= =?us-ascii?q?gcBCgEBAwmICy2CKgEB?= IronPort-PHdr: A9a23:UHScKBH334tgg98HVmtP8J1GfwpLhN3EVzX9CrIZgr5DOp6u447ld BSGo6k30BmUAM6DuroE07OQ7/q7HzRYoN6oizMrSNR0TRgLiMEbzUQLIfWuLgnFFsPsdDEwB 89YVVVorDmROElRH9viNRWJ+iXhpTEdFQ/iOgVrO+/7BpDdj9it1+C15pbffxhEiCCybL9sI xi6twXcu8kZjYd+Lqs61x/FrmdVd+hMym5kO1yekwzg6sus+ZJo7jhdte8m+8NcS6vxYr42T aZfDDQoMmA14NPkuBzeRgaR5XUST3sbnANQDwfK8B/1UJHxsjDntuVmwymVIdf2TbEvVju86 apgVQLlhz0GNz4992HXl9BwgadGqx+vuxBz34jZa5yTOfFjfK3SYMkaSHJCUMhMVyJPHI2yY IkBD+UdM+lXoIbzqkASrRa9HwSgGP/jxyVKi3LwwKY00/4hEQbD3AE4BdwOsHXUrNH0NKcKS eC60rTDwjXZYPNM3jf98ZXIchE/rvGWRrJ7bM3cyVEvFwPEilWQqJTlPyuL2egXvWmU9fBgV eW2i246qgF+vCKvxtw3h4nShYIUylbE+jtlwIovPtK3Vld2bNi5G5Rfqy+ULZF5Qt8+Q252o iY6zKULtJq1cSQXx5oq2RHSZv6HfoWL4B/uW+mfLzlkiH9rd7yyiQi+/FWhx+DhSsW53lRHo yVZntfMtX0A0wHe58iIR/Z740yv1zGP1wXJ5eFFJ0A5jbHbK5k8wr4qipUcr0rCETXsmErol qOWcV8k+ueu5u/6YbvmvoeRO5Johgz6KKgih9KzDOciPgQTUWWW9v6w2bn+8UD/Xb5ElOc5k rPDv5DfPckbo6m5DBJL3Ys78Ba/Cium0MwfnXkaMFJJYBKHgJbtO1HJOP33CeqzjlCynDtx2 vzLP77sDo/QInTZjbvsebBy51ZdyAo1099f+4pZBqwdLP/3QEP9qcLUAxwjPwCpzevqB89x2 4cDVW6XB6+WKqLSsVuG5uI1JOmMYZcYuC79K/gk4/7ujGc5mUcDcqWz05oYcmq4HvN/I0WEY HrjnM0BEXwRswolT+zriFuCXiBPZ3qoRK0z+Ck3CIS9AojbXICinKSB3DunHp1Rfm1KFEiAE W30eIWcR/cMdCWSL9d6kjwFULiuUZUh1RK1uQ/hyrpnK/Db+jcbtZ75yNd6/fXflQsu+jxsE 8Sdz2aNQnl7nmwVXDA6xbh/rlZhylif0ah3nedYGMdI5/NOTwc6L4LTwPJ0Ct/oQALOYM2FS FG8QtWpUnkNSYcKwtoJZQ5YEs+pjhGLizGrBrYPlJSQBZk96KGa1HGnY45yx3yDzKA9hFkrW YMbOmGsw7Z26wPTCpXhiEKEja2naq0G0WjK7mjVnkSUu0QNaA5xVaTdRX1XWULMqs3k507YV Pf6EbQmNgpZ0cPENaJQbcT0jFhcX9/4O8XYbn73kWrmVkXA/a+FcIe/IzZV5y7aEkVRy2gu IronPort-Data: A9a23:J4a23qCaBA/sExVW/2Tiw5YqxClBgxIJ4kV8jS/XYbTApGl03zIFn GAZXjjTbKmCM2Gkf9kgYI6/8kkH6JDTz9c1OVdlrnsFo1CmCSbm6XV1Cm+qYkt+++WaFBoPA /02M4WGdoZtJpPljk/FGqD7qnVh3r2/SLP5CerVUgh8XgYMpB0J0HqPoMZkxN826TSFK1nV4 4mr+peHYAXNNwNcawr41YrS8HuDg9yv4Fv0jnRmDdhXsVnXkWUiDZ53Dcld+FOhH+G4tsbjL wry5OnRElHxpn/BOfv5+lrPSXDmd5aJVeS4ZtW6bID56vRKjnRaPq/Wr5PwY28P49mCt4gZJ NmgKfVcRC9xVpAgltjxXDEICSZbHJxYoobILEqCq+y5xWfCanzzlqAG4EEeZeX0+85EWDAUs 6VGeHZUKEnSsopawpriErgq355zapCwYMVO4xmMzhmAZRoiaYjDQqHL/cdVmig5nMdXAPfTf dExcjl+ahncJRdCUrsSIMlkwrv31iiiG9FegAiuvfcZoE3w9jRWiLvWK/z4JOGhWPwAyy50o UqDpQwVGCoyL92awCCG2mmtg+bVnmXwUeo6G7Gys+ZjnFaTy3c7ExoLT1C2vvCjhwi5Qd03F qAP0nN2/O5rrhztF4KhGUzhyJKZgiMhtxNrO7VSwGmwJmD8um512kBsovV9hBDKeSP4qfHGF rNEoj8xOQFSjQ== IronPort-HdrOrdr: A9a23:u4lylKuSKQZgpvu63QkyajRq7skDY9V00zEX/kB9WHVpm6uj5q WTdZUgtSMc5wx/ZJhNo7290ey7L080lqQFg7X5X43IYOCOggLBEGgh1+rfKlbbcREWmNQw6U 4tSdkcNOHN X-IronPort-Anti-Spam-Filtered: true Received: from unknown (HELO [192.168.1.19]) ([109.128.134.91]) by relay.proximus.be with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Nov 2022 00:46:42 +0100 Message-ID: <58b7e58d0c88199794cf08dc10ade443d36bccd1.camel@skynet.be> Subject: Re: [RFA] When getting the locno of a bpstat, handle the case of bp with null locations. From: Philippe Waroquiers To: Simon Marchi , gdb-patches Date: Mon, 21 Nov 2022 00:46:41 +0100 In-Reply-To: <5464181b-9de6-c242-cdac-58efbf262437@simark.ca> References: <20221120173024.3647464-1-philippe.waroquiers@skynet.be> <5464181b-9de6-c242-cdac-58efbf262437@simark.ca> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3.4 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Sun, 2022-11-20 at 14:34 -0500, Simon Marchi wrote: > I ran the testsuite with the patch applied, I saw these unexpected > failures when running with native-gdbserver or > native-extended-gdbserver: > > FAIL: gdb.base/step-over-syscall.exp: detach-on-fork=off: follow-fork=parent: break cond on target : fork: continue to marker > FAIL: gdb.base/step-over-syscall.exp: detach-on-fork=off: follow-fork=child: break cond on target : fork: continue to marker > > I bisected, and it pointed to the locno patch again. Probably the > expected patterns that need to be updated? Effectively, this test contains some parts running only with gdbserver, and I missed the needed update of the pattern. I have posted an RFA with a fix: [RFA] Fix step-over-syscall.exp matching regexp for $bpnum.$locno matching https://sourceware.org/pipermail/gdb-patches/2022-November/194020.html > >     continue^M >     Continuing.^M >     [New inferior 2 (process 1262224)]^M >     ^M >     Thread 1.1 "step-over-fork" hit Breakpoint 4.1, marker () at /home/simark/src/binutils-gdb/gdb/testsuite/gdb.base/step-over-fork.c:22^M >     22 marker () {}^M >     (gdb) FAIL: gdb.base/step-over-syscall.exp: detach-on-fork=off: follow-fork=parent: break cond on target : fork: continue to marker > > However, I confirm it gets rid of the UNRESOLVEDs due to the ASan > complaints. But I don't have time to look at the code right now, sorry. Thanks for testing and pointing at these regressions (and sorry about these). There are now 3 RFA fixing some regressions [RFA] Fix use after free introduced by $_hit_bpnum/$_hit_locno variables. [RFA] When getting the locno of a bpstat, handle the case of bp with null locations. [RFA] Fix step-over-syscall.exp matching regexp for $bpnum.$locno matching and a fix for an unrelated problem but discovered when validating the above: [RFA] Fix jump on uninit producer_is_clang of cu.h, rm declared/undefined find_partial_die The week-end was too busy with the above to search for the dwarf2 leaks also found while validating the fixes. I might have time next week-end. Thanks Philippe