From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 881493858D33 for ; Fri, 5 May 2023 15:58:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 881493858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1683302318; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=nR/q9L9AEple2IHswzw61pwxFB0JPsUpX9OwIFbkm4E=; b=b+cPMOMmj0Ek0acRru6k6Gut8uWlmVAQlZgyfnKsScbwHnFRERRBI0plOCKaEd3+oXP3qr 59B11O8/JC/xIJBlOeL4WnLDSBz73Olhxk8sRH9xrrDzTgqEyAeaFDvVXmItbwDOb+ja5W Kj/WY40Vg2KiW3O+NsIFXI/Ak53sBq0= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-616-cEuy5xGIPUG5Kk78DjOJOA-1; Fri, 05 May 2023 11:58:37 -0400 X-MC-Unique: cEuy5xGIPUG5Kk78DjOJOA-1 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-3f1745d08b5so8645445e9.1 for ; Fri, 05 May 2023 08:58:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683302315; x=1685894315; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=nR/q9L9AEple2IHswzw61pwxFB0JPsUpX9OwIFbkm4E=; b=U4Muk9OFY4VFJ7MQWqXsidl+Dm1c7irUBJdkvq8lGzGnAfwQ4qPMe/y3/05cXO8XqO lN6n2/8qZObZP7ak1XMLSGHD99rV7L2GeNtWOZQ5OxpbpHsboTKy8kejP8WZ9nkN8khu Pe3bjDe/c6zmZW4Wx2Gm6dKmw6ITLNGRW5TBNeeG1V3h8qybA4n4rkZSj9UvGezm1PFU 2Mq3VP55iN6SPh7kJjLjgBig/9svHoZ3ljuSpk+DA2cfJKXP5xjiD35N4uIQVAWPN6NH A6YAtZeo1gtcclAeYHc6y+RDx8pgFqY1zkRsv1+IIbh4l/PpREt1P0IANBJ/hBF6ZNCw pUAw== X-Gm-Message-State: AC+VfDxWXU2ULpzptFhSOXtRggGng4TrLWMvclsbAyD2nuDgfG+ugccg L1DaQtNaAUc3szZCDqpJr8mdL3PFvcIz8EeEGh7gPkfiSCjFiu+NhJsGb9tdT8UD8E52XYwQnjP ASS1Ss975AYr/V87Gd6HfkNR1239jYczzBPSEqZaYh33JotP3KcWYDU5ZVcoqylsMOC4i33ORf5 5bDX8TDA== X-Received: by 2002:a7b:cd0b:0:b0:3f3:fe82:ee8e with SMTP id f11-20020a7bcd0b000000b003f3fe82ee8emr1385624wmj.40.1683302315675; Fri, 05 May 2023 08:58:35 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4U+aj+6EoEp2cD3dS9fZ58+s2S823JWtDClImiMPWMOE27XIxuHsN6F+fk+ED/6Cwy0mdlKg== X-Received: by 2002:a7b:cd0b:0:b0:3f3:fe82:ee8e with SMTP id f11-20020a7bcd0b000000b003f3fe82ee8emr1385607wmj.40.1683302315266; Fri, 05 May 2023 08:58:35 -0700 (PDT) Received: from localhost (11.72.115.87.dyn.plus.net. [87.115.72.11]) by smtp.gmail.com with ESMTPSA id o18-20020a05600c379200b003f17300c7dcsm8319644wmr.48.2023.05.05.08.58.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 May 2023 08:58:34 -0700 (PDT) From: Andrew Burgess To: gdb-patches@sourceware.org Cc: Andrew Burgess Subject: [PUSHED] gdb/testsuite: tighten patterns in build-id-no-debug-warning.exp Date: Fri, 5 May 2023 16:58:33 +0100 Message-Id: <58d047ac2597d7b9e89e1723aaf67dfe51f8117b.1683302295.git.aburgess@redhat.com> X-Mailer: git-send-email 2.25.4 MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-Spam-Status: No, score=-11.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Tighten the expected output pattern in the test script: gdb.debuginfod/build-id-no-debug-warning.exp While working on some other patch I broke GDB such that this warning: warning: "FILENAME": separate debug info file has no debug info (which is generated in build-id.c) didn't actually include the FILENAME any more -- yet this test script continued to pass. It turns out that this script doesn't actually check for FILENAME. This commit extends the test pattern to check for the full warning string, including FILENAME, and also removes some uses of '.*' to make the test stricter. --- gdb/testsuite/gdb.debuginfod/build-id-no-debug-warning.exp | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/gdb/testsuite/gdb.debuginfod/build-id-no-debug-warning.exp b/gdb/testsuite/gdb.debuginfod/build-id-no-debug-warning.exp index 1102d9bf254..b49770f4a5e 100644 --- a/gdb/testsuite/gdb.debuginfod/build-id-no-debug-warning.exp +++ b/gdb/testsuite/gdb.debuginfod/build-id-no-debug-warning.exp @@ -87,10 +87,12 @@ gdb_test_no_output "set debug-file-directory ${debug_file_directory}" \ "set debug-file-directory" # Now load the file into GDB, and look for the warning. +set debug_file_re [string_to_regexp $build_id_debug_file] gdb_test "file ${build_id_debug_file}" \ [multi_line \ - ".*Reading symbols from.*debuginfo.*" \ - ".*separate debug info file has no debug info.*"] \ + "Reading symbols from $debug_file_re\\.\\.\\." \ + "warning: \"$debug_file_re\": separate debug info file has no debug info" \ + "\\(No debugging symbols found in \[^\r\n\]+\\)"] \ "load test file, expect a warning" # Now we should close GDB. base-commit: 233239384c7a050dd590971d75233c49b12f8d85 -- 2.25.4