From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 9F42E3858C74 for ; Tue, 20 Sep 2022 16:54:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 9F42E3858C74 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-213-clmCXIYkNQe5C4C7BSFGDw-1; Tue, 20 Sep 2022 12:54:48 -0400 X-MC-Unique: clmCXIYkNQe5C4C7BSFGDw-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id ACF1F80206D; Tue, 20 Sep 2022 16:54:47 +0000 (UTC) Received: from [10.2.17.232] (unknown [10.2.17.232]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 41C042166B26; Tue, 20 Sep 2022 16:54:46 +0000 (UTC) Message-ID: <58d119d3-670b-bb3e-13ff-9f2adbc14fc6@redhat.com> Date: Tue, 20 Sep 2022 09:54:45 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH] gdb/csky add cskyv2-linux.xml for cskyv2-linux.c To: Jiangshuai Li , gdb-patches@sourceware.org References: <20220920094515.58156-1-jiangshuai_li@linux.alibaba.com> From: Keith Seitz In-Reply-To: <20220920094515.58156-1-jiangshuai_li@linux.alibaba.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.4 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Sep 2022 16:54:52 -0000 On 9/20/22 02:45, Jiangshuai Li via Gdb-patches wrote: > Add cskyv2-linux.xml for re-generating cskyv2-linux.c if needed. Thank you for posting this! I have a patch waiting for it. :-) > gdb/features/Makefile | 1 + > gdb/features/cskyv2-linux.xml | 102 ++++++++++++++++++++++++++++++++++ > 2 files changed, 103 insertions(+) > create mode 100644 gdb/features/cskyv2-linux.xml I think that cskyv2-linux.c needs to be regenerated. If I apply your patch locally, it does not give me the same file back. [I believe this is because cskyv2-linux.c was not properly generated when it was committed.] For example, create_feature_cskyv2_linux should take two arguments, but the committed file only takes one (partial diff against locally regenerated cskyv2-linux.c): -static void -create_feature_cskyv2_linux (struct target_desc *result) +static int +create_feature_cskyv2_linux (struct target_desc *result, long regnum) Otherwise, LGTM, and I would encourage a maintainer to approve this. Keith