Re: [PATCH] gdb: make timestamped_file implement can_emit_style_escape

[Simon Marchi <simon.marchi@polymtl.ca>]

> Simon> Making
> Simon> timestamped_file implement can_emit_style_escape (returning the value of
> Simon> the stream it wraps) fixes it.  To show that it works, modify some
> Simon> logging statements in auto-load.c to output style filenames.  You can
> Simon> see it in action by setting "set debug auto-load 1" and running a
> Simon> program.  We can incrementally add styling to other debug statements
> Simon> throughout GDB, as needed.
> 
> This looks good to me.

Thanks, will push.

> I've also wondered what it would take to style error() text.  Maybe just
> checking the styling of gdb_stdout when creating the error would be good
> enough, it's not like gdb often stores exceptions and then later reuses
> them.

Indeed.

> Another thought was to have styling always be emitted, then optionally
> strip it out just before display.  However, user 'printf's can also emit
> styles and one wouldn't want to strip those...

Or the error string could be saved in an "unrendered" form that
includes the text and its styling.  And only render it (with or without
style) when we print it.  As an exercise, we can try to think how we
would do it if different uiouts in the same GDB had different methods
of styling, and the error had to be printed on all those uiouts.  We
couldn't bake a styled string when emitting the error, we would have to
render it once for each uiout.

Simon