From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM04-DM6-obe.outbound.protection.outlook.com (mail-dm6nam08on2051.outbound.protection.outlook.com [40.107.102.51]) by sourceware.org (Postfix) with ESMTPS id 927FC385843E for ; Thu, 14 Apr 2022 14:01:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 927FC385843E ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lZlYjxgc4lTYgoT3gushFU5gfOOLrSdU8wbsEOk00YMeNwXTahEqGtg+fyUpE5ZH23P4Szn4pbCJ7xmPA0TmJvBxxbGnOwPJ1mmeRC/8axbxdPO4/eQelcH/7K08J3kHDUTgIJrS5TS/wnvN7V7mrD3AYasBmfMNzdA4MZU7o96Ae+W/XLM3Mb18+/aQqJm407cFVIZIHbgo+wZbn3Y0s2ttokVa9riGD+MA0XWH95txVmQ0PC3ksZ0rT/bk49eot2uO4BCV77izU90J/h07j9eJ2ilIge+Ni/iRq4/6XXLZvkvJCS8IhYv+J9ZuSp/GRv76+CKLVooo8SyiQlxFag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Deh3SXO3OfvZi2oK7Bju/7QmEdEsDJGxWTUNLoyRxFo=; b=ItYg+se9eH/2/CQEjkdqN4zdwdYMZhME1aXp6TgRk4nP0S6DzUlHFhWLRFzlwl2Ps0gCAeHil0Hj4pHKngAl4Au5zqD0CwuwgvZoW6aCXK3e6ZYpgi77620gMsUbMxTykd/Ljuma8Rq/O8bjPqVRYjgbw+MVgfNc7RTBzf6vzjtSdqz7zt+oioghiz0GheIefd1qBLv2B0gR1psHpq8jKGgs0cOkfVU2aojV4bqiq9xgGlMEdTw+Hj+3/T19I+M11Nlm2daIrSdnCVTuN+KZh1yGsjRgYhkJLLrEOL5x40EFiZ9mZiVwbSxhT7//8ynq8sZlmc+olybbQMjCuxRxjg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none Received: from PH0PR12MB5452.namprd12.prod.outlook.com (2603:10b6:510:d7::16) by DM6PR12MB3386.namprd12.prod.outlook.com (2603:10b6:5:115::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.29; Thu, 14 Apr 2022 14:01:30 +0000 Received: from PH0PR12MB5452.namprd12.prod.outlook.com ([fe80::91ae:2b15:fc7b:23b1]) by PH0PR12MB5452.namprd12.prod.outlook.com ([fe80::91ae:2b15:fc7b:23b1%6]) with mapi id 15.20.5164.020; Thu, 14 Apr 2022 14:01:28 +0000 Message-ID: <58fce617-9376-3f0b-7ffc-828178f0af09@amd.com> Date: Thu, 14 Apr 2022 15:01:21 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH] gdb/testsuite: Introduce and use gdb_spawn_attach Content-Language: en-US To: Simon Marchi , gdb-patches@sourceware.org Cc: lsix@lancelotsix.com References: <20220414113210.363239-1-lancelot.six@amd.com> <8a1bc97d-7477-e8de-2701-245cac119284@polymtl.ca> <27505c64-59a0-9487-f036-35210d17ff49@polymtl.ca> From: Lancelot SIX In-Reply-To: <27505c64-59a0-9487-f036-35210d17ff49@polymtl.ca> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P265CA0161.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:9::29) To PH0PR12MB5452.namprd12.prod.outlook.com (2603:10b6:510:d7::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f001ad44-4905-4b38-f7f4-08da1e1f4502 X-MS-TrafficTypeDiagnostic: DM6PR12MB3386:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 20wKDoJVYHWq6GS67nl7HAnNOmUB7zayy5dBd4HyDZlmd9JDH6xSp1wHcNVUeo0t84RcztOtscm/kmddPZS96P/EVzcKyD8MwzYx4Okjxk87bvAp08fUx71xZIQgoJEWmYztBG3bbXxROxFN8XmT5cy8nJhtypq3PO359K7bYiK3HV/EjtAPobjP0UHOeWjhq5pgjLbTVNgUUi9herNQ3UGTT5mcu5XhTqh3wl3NftUngEUO35zOdLm9UPSndy/QbALqOS4ZSHfePPypGj09VLNyY43DcZ1kAlVYzgw5pNfeyu3nH7cQNMP12NYF5NXFIb/k++MUJof2VRIl9aYXkFCW4KqEATuRXeSrgT3tnMMZvuIVi/ZYi5+Bc7A0bFezMcn5Y66+OCwGG/FLBbX27Gw6I3HOrq3i0NDjNMpnp0BNsZ1HL/BNvTavtX80nqbk2yAKrY7TPxW7H44GKlg94wF4in0dBK2ca6BUlZ62MdWTDDZTbX7sKhp3dz5RZHhK6GOiI7ufM/XEdwakmsedU07fF0KOHxdyPDcaysd1OcC+Sm+FvjUrS+/oy7tNqrrxUDEwV0kmZr+AFlRKp3RhRMNRQu+k6LPitocIZMlXflZBiF66Ykalc6DGxql5N/i6T8aWQVFZIz7GUUEwwXgGsSG1cTr7nhZCypxdR9pwhtlEyq7ut03uCeOji+KLNX1ZRr42+dbRbEHwvEmaI/Vi6feKiMcfG5osOL0w0scjioZ4htYW58SnLVsPZ2+I5C7UCmnAfjUQkkf9Z+GSyUBanhA0HpLi7IG7SQqE07oQPM2Lq7GBx8nqLZCGAhrSGLk5 X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR12MB5452.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(66946007)(4744005)(38100700002)(2906002)(66556008)(83380400001)(31686004)(2616005)(186003)(31696002)(6506007)(6512007)(6666004)(66476007)(86362001)(5660300002)(8676002)(4326008)(8936002)(508600001)(966005)(6486002)(316002)(36756003)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 2 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?N3AvM2pST2Q5ZXlQQXNEd3pnZlhqWUN2S0tyNEIyVzVQeDgxMVVRV1U1SzRp?= =?utf-8?B?YllISDlBNWtacXlCa285RlpNSWExbHFpT3JBTncxMVMxN01NNGlSeHBsT1hS?= =?utf-8?B?SEMzVTB5TlkyckpuNFpta0tQOFh1VTFPTGhNNDZZT3NFU3JUUUI5REFFUC9x?= =?utf-8?B?WmxRZVRLSzlYbjRDb3hrM1FFUkJxc1RLRjhGM0NWTnVid0s3TXZHRDBwQ2xw?= =?utf-8?B?VWZ6WFRFeGtuNnhNY1Y5dWZvMnQ0alIzdWQ5emlnbC9IenlLeFBDWmNEZEVw?= =?utf-8?B?RlJ2empqcWhLUDNFU2FXUHdkcjVrdGNYZGVFczJsQ2JkanlwaXpOV0Eza016?= =?utf-8?B?ZnNXL1htQ1NHZ0poQmRzb3MzcVJvckpOOUJVaVF6Q2c3b2ZNZ3g5TnNXZmcz?= =?utf-8?B?eGQreUJFaXdCcytsQXB6c0xpai90Q2FsRnlmK0JrQW01aCtPN3hRb2pYNkFV?= =?utf-8?B?UGpQSk8wRnBPemQwMzNROVJLcFpXQUFndlEwSHNPMUNTMW1pRXV5aXdubGIy?= =?utf-8?B?YlFnNjh6UDFKWkh1OFFKVks2NTlrT0d4MmhidmM1cEE3eXlSMGtFeFBvNHNS?= =?utf-8?B?SWhnTDkvODB4VFZYdlUxOXdFeDRGeWZSanlydDZwOTVIbFJXVzU3NGZjTjda?= =?utf-8?B?akovaG1JWXNwQjlqVkExdEpPVzlWbFF5bHprTzU4dXFZWEEycllRNUJyS1Fs?= =?utf-8?B?bHU3LzYvczJ0M25QOW1rVzRCY1pMa1dya1JTK1c1NVdkUmN1UnB2NHNOdnhh?= =?utf-8?B?cXVkOXB2WGpMK3VidnN4RlpPaEZzVVFHS1JGYVBrSnBWTEpKQU1ia2FzYU5B?= =?utf-8?B?V0Jid1haZjFCVThVeXV3dXZ0ZWIwUTQ5VkFvTkpjZnlxek9FRXR3dlZtbzNB?= =?utf-8?B?SzlPUDRkOExEVkM2WnRoZXMwZytHQWMxeVVmdHRlMnRQWlpmRG9TSjZrM0ZR?= =?utf-8?B?TE1udFRQdGRUL2l2QlVIeFcwSzVsNWRyWjZ6WFpjRy9QSFdhNFNyMzR2TE40?= =?utf-8?B?MWRONTBVcUlpUlc0d2xvc0Mrd2ZJRjhjT2tqT0NuOUFqcjRxQ2pGOXlEbFU1?= =?utf-8?B?SU5oL01kUlpZSjAzUEN2ZEl3alRPWFYxK2JDVjNhNXJYL0JNMEhwWE9lN3lL?= =?utf-8?B?RTl1QUdEV1VzSS81V29pT2g0RjZiVkJnbEUzYUsvVU9WWGU4STB3bzZkOUhE?= =?utf-8?B?SEt0L1FxVmhHc3VEdXR3NW5SQTZyKzcvZTBBTXg4Q0QxRC9sVWIyZkwvQkV5?= =?utf-8?B?NDhYQ3RiRkJndXlYa0Q5Z2dOZ1NOTVcwd08vWUpmbWpoYnFNUEtkaHl0bjkw?= =?utf-8?B?U3RZbm84YUtUMUptNmxGdTQ5YWZxRmVSRnNId3ovZTB0N0luQnd6U3R3OHRF?= =?utf-8?B?S0ZobGtHM2lUallIVDRnbDhjQ1ZNOVBvUTAvMjFrR1ljUnArTjFlb3Q5N3Ns?= =?utf-8?B?bXBtZ0lwV1ppSEZ5SW50ZkN3U0V1NFhDZnZwUW94cmwxRmtLUUdZa1R3SUlq?= =?utf-8?B?UHlDWjcyUDhlWkI0NS9IYmJlRTdiSkx2Zi9UQXM4NWZrNjkrNDhLdVlXQVNz?= =?utf-8?B?YlZ1WXpTRjVUQ0tlTWVyMm9qVU81TUZ1ME04TExYVU1nTGFsUkRoZUQ1c2JJ?= =?utf-8?B?R0xYSmV2bGkwM2xSUEFTK3JrWkVIdk1pTXAvalppQ1YxTkljMnNGTUhDNlZh?= =?utf-8?B?Rm55eDBSYUhLWnN0U004ZytjZUtCVHdLK3hibm4yaDE0NEVDc0V4SWJRbzQv?= =?utf-8?B?VU53czZ5N0FGM1pobU9NY0MxaDhWSzVNQytid0FsRzR0L1FVSGdUTXJnRms5?= =?utf-8?B?TjZiaEFZOUZlQ0VEOVN6WjZpVlVuM0djR0V0OUJ0K042M3hzTlVwYWFObVl5?= =?utf-8?B?eVJXWlN4UXdUMVF4clUya2E5WUl4bW5iM0ZxVnZEL3NKK3dJR3pZSFlscEJE?= =?utf-8?B?b25BWDRmR0RNaEk1Y3ZWVW1OVlNtZ29NSGRvYjlUTUw4blhTSUJZRytsSGhh?= =?utf-8?B?SVdvV0VFc2Y2QXdrMjZQL2Fmakt0cElwVVFZQnhoSVcvbGZmaFV4T2tCY0tX?= =?utf-8?B?bDRncFk0bzE4TmVxOUgxbHNUVWtGYisxZm5KcjZ5QWpXY1RRUU5wU2VUUjY5?= =?utf-8?B?aDhPc2ZOT1QxanQ2YUtITnJaKzNuLzB2RVI0NlhPUzZQNVhBVzcvOVdMUGtL?= =?utf-8?B?SGZXOGp3TXNYYzZka0FTKzRIY0h0WjhSVDltelpkci9GOXAwMEF4TjFDT0xv?= =?utf-8?B?MnRlWHRubzNpN3lGN2FYb1UwSERpemtkSjVNbFRZcW5kZjUvUXNYd0YwdGZx?= =?utf-8?B?V05GRUpmZXNUMlhDK3NrU05ES1h3SWo2Wm9TS0s3ZS9tVHowNmFld3Z0YnJD?= =?utf-8?Q?Xo8DVTSL58hJYUTB0YG6EdSL+YZx++5v2lgs4ykT0kwkQ?= X-MS-Exchange-AntiSpam-MessageData-1: LTP3UdbIFcFS3w== X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: f001ad44-4905-4b38-f7f4-08da1e1f4502 X-MS-Exchange-CrossTenant-AuthSource: PH0PR12MB5452.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Apr 2022 14:01:28.0112 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 4MwpF3rweHrYupFWldEY81QjLVKQbwHN/ML9yhsT072qU4N8Q+MNdZs9FOSYbsQf/IwVVElazMq/XiGaC8a8Bg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB3386 X-Spam-Status: No, score=-5.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, KAM_SHORT, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Apr 2022 14:01:35 -0000 >> >> It comes down to default_gdb_spawn which already use some perror MSG before it return non-0. So from what I can see, it is already covered. > > Hmm, I think that perror just influences the result of the following > test to be recorded, right? So if there is not subsequent gdb_test, > because the callers just return and do nothing, will the failure be > visible? Maybe it is, I just want to be sure. > It actually does both[1]. It prints the message and affect the next pass/fail. In such case, I guess I should also issue a fail before returning, so it does not affect subsequent tests. The fail fill report as UNRESOLVED. Something like set res [gdb_spawn_with_cmdline_opts "--pid=$testpid"] if { $res != 0 } { fail "start gdb with --pid" return 0 } [1] https://www.gnu.org/software/dejagnu/manual/perror-procedure.html