From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id 28131386D62A for ; Thu, 6 Jul 2023 15:07:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 28131386D62A Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=us.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=us.ibm.com Received: from pps.filterd (m0353726.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 366ElTlw016772; Thu, 6 Jul 2023 15:07:49 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : subject : from : to : cc : date : in-reply-to : references : content-type : mime-version : content-transfer-encoding; s=pp1; bh=LM7co2aiq7Z4WgxNbqAkioV9HJvYEf+lNXly7qH+0bU=; b=CU+7LqtzliHZp7tkkJDEQILUpBwQm2xIHQJdbSYNIrWsWS7zu4bjAZiQa4T7ncqh5JPd FF8kZiCw7rloetAiBK1bLOWl/n+yJ3i8PpfTPeXelRZYKB6CSbpyNaf9pa9fQItFxBlR kNBSy5W2ijSi6abV/T0JSPRtSp466XxdgrjrwVd0UIUaqU+qAg+TZQ5MTmvlZXYaA6/J F7tog0GlBeIXvTZg0ZaZY11LOoEasebjlRT/0kIV1C8AwsKI11tlupzDF8FZvFzQyPhp F5++nOO7UkvY8lkG2BlXhkIhdj6pJVpxwM7EW72+HgHBlWIKcldORdx8F8FFgRx8Ucz1 eg== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3rnypfgtej-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 06 Jul 2023 15:07:49 +0000 Received: from m0353726.ppops.net (m0353726.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 366Em408017705; Thu, 6 Jul 2023 15:07:48 GMT Received: from ppma01wdc.us.ibm.com (fd.55.37a9.ip4.static.sl-reverse.com [169.55.85.253]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3rnypfgta7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 06 Jul 2023 15:07:48 +0000 Received: from pps.filterd (ppma01wdc.us.ibm.com [127.0.0.1]) by ppma01wdc.us.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 366CPvrJ005070; Thu, 6 Jul 2023 15:07:46 GMT Received: from smtprelay06.dal12v.mail.ibm.com ([9.208.130.100]) by ppma01wdc.us.ibm.com (PPS) with ESMTPS id 3rjbs5s4ur-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 06 Jul 2023 15:07:46 +0000 Received: from smtpav05.wdc07v.mail.ibm.com (smtpav05.wdc07v.mail.ibm.com [10.39.53.232]) by smtprelay06.dal12v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 366F7iQ464225550 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 6 Jul 2023 15:07:44 GMT Received: from smtpav05.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 408D958067; Thu, 6 Jul 2023 15:07:44 +0000 (GMT) Received: from smtpav05.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 66AD95805F; Thu, 6 Jul 2023 15:07:43 +0000 (GMT) Received: from li-e362e14c-2378-11b2-a85c-87d605f3c641.ibm.com (unknown [9.61.18.149]) by smtpav05.wdc07v.mail.ibm.com (Postfix) with ESMTP; Thu, 6 Jul 2023 15:07:43 +0000 (GMT) Message-ID: <590702f9ec48b8972e8665e3ab0585300493e890.camel@us.ibm.com> Subject: Re: [PATCH 1/2 ver 2] Fix reverse stepping multiple contiguous PC ranges over the line table. From: Carl Love To: Simon Marchi , Bruno Larsen , gdb-patches@sourceware.org, UlrichWeigand , pedro@palves.net Cc: luis.machado@arm.com, cel@us.ibm.com Date: Thu, 06 Jul 2023 08:07:42 -0700 In-Reply-To: <86caeaa0e3fc77026118531562832aa622621db8.camel@us.ibm.com> References: <74630f1ccb6e9258ae60682105ee5490726fb255.camel@us.ibm.com> <46d73c69-9168-44c6-b515-23dd893fc0eb@redhat.com> <86c65f2ad74caffc162f100e4e9c5be9062a7f59.camel@us.ibm.com> <0a2c4ebd-f01d-4b96-1b13-25d7276056a5@redhat.com> <956b8c3c9a7bdc3aa6f9a040619ec4778edc9c94.camel@us.ibm.com> <89b2fb027024f7e97de7196ee091a0ca11c0c2b3.camel@us.ibm.com> <0943e12c-049d-f8b0-c4c5-8816b1be1e45@simark.ca> <961a88a7-a820-fd32-c7ee-e707697e22a5@simark.ca> <60ba16fb9207f7e6313265aa0a118f65787b52f7.camel@us.ibm.com> <95df539fed378baea3dd679bb10d33c57260f318.camel@us.ibm.com> <4ab1e3ff-eede-5573-f58f-63ff8b1e23bb@simark.ca> <86caeaa0e3fc77026118531562832aa622621db8.camel@us.ibm.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5 (3.28.5-18.el8) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: bLb628-wKO1hO5THqP2_58YjELA0BlF1 X-Proofpoint-GUID: cuurs7zs0wJw0Li3erPMo2qUnLIGQTyA X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26 definitions=2023-07-06_11,2023-07-06_02,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxlogscore=944 lowpriorityscore=0 malwarescore=0 suspectscore=0 bulkscore=0 adultscore=0 phishscore=0 spamscore=0 impostorscore=0 priorityscore=1501 mlxscore=0 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2305260000 definitions=main-2307060135 X-Spam-Status: No, score=-11.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: GDB maintainers: I believe Simon is on parental leave now. He mentioned in a private email before he sent the last set of comments that he was expecting to go on parental leave shortly. Just wondering if anyone else would be willing to take a look at my feedback on his questions and changes per his comments to see if we can move these two patches forward. Thanks Carl ------------------------------------------- On Fri, 2023-06-23 at 13:04 -0700, Carl Love wrote: > Simon, GDB maintainers: > > Version 2, updated the compiler check and handling for gcc version 6 > and earlier. Retested on Power 10. > > Per the comments on version 4 for the gdb.reverse/func-map-to-same- > line.exp, I have added support to proc gdb_compile to enable or > disable > generating line information as part of the debug information. The > two > new options are column-info and no-column-info. > > This patch implements the new options for gdb_compile. > > These options have been tested with patch 2 of 2 on PowerPC with the > GCC and clang compilers. > > Please let me know if the patch is acceptable for mainline. Thanks. > > Carl > > > > > ----------------------------- > Add gdb_compile options column-info and no-column-info > > This patch adds two new options to gdb_compile to specify if the > compile > should or should not generate the line table information. The > options are supported on clang and gcc version 7 and newer. > > Patch has been tested on PowerPC with both gcc and clang. > --- > gdb/testsuite/lib/gdb.exp | 34 ++++++++++++++++++++++++++++++++++ > 1 file changed, 34 insertions(+) > > diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp > index aed7e2d043c..5857c59a47a 100644 > --- a/gdb/testsuite/lib/gdb.exp > +++ b/gdb/testsuite/lib/gdb.exp > @@ -4794,6 +4794,8 @@ proc quote_for_host { args } { > # debug information > # - text_segment=addr: Tell the linker to place the text segment > at ADDR. > # - build-id: Ensure the final binary includes a build-id. > +# - no-column-info: Disable generation of column table > information. > +# - column-info: Enable generation of column table information. > # > # And here are some of the not too obscure options understood by > DejaGnu that > # influence the compilation: > @@ -5003,6 +5005,38 @@ proc gdb_compile {source dest type options} { > } else { > error "Don't know how to handle text_segment > option." > } > + } elseif { $opt == "column-info" } { > + # If GCC or clang does not support column-info, compilation > + # will fail and the usupported column-info option will be > + # reported as such. > + if {[test_compiler_info {gcc-*}]} { > + lappend new_options "additional_flags=-gcolumn-info" > + > + } elseif {[test_compiler_info {clang-*}]} { > + lappend new_options "additional_flags=-gcolumn-info" > + > + } else { > + error "Don't know how to handle gcolumn-info option." > + } > + > + } elseif { $opt == "no-column-info" } { > + if {[test_compiler_info {gcc-*}]} { > + if {[test_compiler_info {gcc-[1-6]-*}]} { > + # In this case, don't add the compile line option > and > + # the result will be the same as using no-column- > info > + # on a version that supports the option. > + warning "gdb_compile option no-column-info not > supported, ignoring." > + } else { > + lappend new_options "additional_flags=-gno-column- > info" > + } > + > + } elseif {[test_compiler_info {clang-*}]} { > + lappend new_options "additional_flags=-gno-column-info" > + > + } else { > + error "Don't know how to handle gno-column-info > option." > + } > + > } else { > lappend new_options $opt > }