From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 50039 invoked by alias); 12 Jun 2017 08:38:10 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 50020 invoked by uid 89); 12 Jun 2017 08:38:08 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_SOFTFAIL autolearn=no version=3.3.2 spammy= X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 12 Jun 2017 08:38:06 +0000 Received: by simark.ca (Postfix, from userid 33) id 565D51E4D7; Mon, 12 Jun 2017 04:38:09 -0400 (EDT) To: Yao Qi Subject: Re: [PATCH] xtensa: Properly strdup string when building reggroup X-PHP-Originating-Script: 33:rcube.php MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Mon, 12 Jun 2017 08:38:00 -0000 From: Simon Marchi Cc: Stafford Horne , GDB patches In-Reply-To: <86poe9aa4y.fsf@gmail.com> References: <20170610133422.19913-1-shorne@gmail.com> <86poe9aa4y.fsf@gmail.com> Message-ID: <590b6ff49c8bc167ca2e179ec14818b0@polymtl.ca> X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.2.5 X-IsSubscribed: yes X-SW-Source: 2017-06/txt/msg00270.txt.bz2 On 2017-06-12 10:22, Yao Qi wrote: > This exposes another bug, IMO, here, > > for (i = 0; i < XTENSA_MAX_COPROCESSOR; i++) > { > cpname[2] = '0' + i; > xtensa_cp[i] = reggroup_new (cpname, USER_REGGROUP); > } > > and XTENSA_MAX_COPROCESSOR is 0x10, so we can see "cp:", "cp;", which > looks odd. Heh, looks like the patch here https://sourceware.org/ml/gdb-patches/2011-03/msg00571.html did not take that into account :)