From: Simon Marchi <simon.marchi@polymtl.ca>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA] Remove a cleanup from parse_expression_for_completion
Date: Wed, 21 Feb 2018 03:46:00 -0000 [thread overview]
Message-ID: <590b765a-66eb-3f33-2921-8b57d931e90d@polymtl.ca> (raw)
In-Reply-To: <87bmgj4dhh.fsf@tromey.com>
On 2018-02-20 03:23 PM, Tom Tromey wrote:
>>>>>> "Tom" == Tom Tromey <tom@tromey.com> writes:
>
> Tom> There is a case in here where the NULL/empty string distinction matters.
> Tom> So I think we can't use std::string but must instead use
> Tom> unique_xmalloc_ptr. I'll update the patch.
Woops!
> diff --git a/gdb/expression.h b/gdb/expression.h
> index 030f2f08e7..59a0898805 100644
> --- a/gdb/expression.h
> +++ b/gdb/expression.h
> @@ -101,7 +101,8 @@ extern expression_up parse_expression (const char *);
> extern expression_up parse_expression_with_language (const char *string,
> enum language lang);
>
> -extern struct type *parse_expression_for_completion (const char *, char **,
> +extern struct type *parse_expression_for_completion (const char *,
> + gdb::unique_xmalloc_ptr<char> *,
This line is now too long.
Otherwise it looks good to me.
Simon
prev parent reply other threads:[~2018-02-21 3:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-16 23:02 Tom Tromey
2018-02-16 23:27 ` Simon Marchi
2018-02-20 4:39 ` Tom Tromey
2018-02-20 5:02 ` Tom Tromey
2018-02-20 20:23 ` Tom Tromey
2018-02-21 3:46 ` Simon Marchi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=590b765a-66eb-3f33-2921-8b57d931e90d@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).