* [PATCH] Remove struct keyword from section_addr_info
@ 2018-03-23 20:36 Keith Seitz
2018-03-24 2:46 ` Simon Marchi
0 siblings, 1 reply; 3+ messages in thread
From: Keith Seitz @ 2018-03-23 20:36 UTC (permalink / raw)
To: gdb-patches
Buildbot pointed out a failiure in windows-nat.c:
../../binutils-gdb/gdb/windows-nat.c:582:10: error: using typedef-name 'section_addr_info' after 'struct'
struct section_addr_info *addrs;
^~~~~~~~~~~~~~~~~
In file included from ../../binutils-gdb/gdb/windows-nat.c:49:0:
../../binutils-gdb/gdb/symfile.h:75:37: note: 'section_addr_info' has a previous declaration here
typedef std::vector<other_sections> section_addr_info;
^~~~~~~~~~~~~~~~~
A recursive grep of the sources for "struct section_addr_info" reveals one
additional reference in a comment. In both cases, this patch simply removes
the struct keyword.
gdb/ChangeLog:
* symfile.c (place_section): Remove "struct" from section_addr_info
in comment.
* windows-nat.c (struct safe_symbol_file_add_args) <addrs>: Likewise.
---
gdb/ChangeLog | 6 ++++++
gdb/symfile.c | 2 +-
gdb/windows-nat.c | 2 +-
3 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index b543904db2..70d182d624 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,9 @@
+2018-MM-DD Keith Seitz <keiths@redhat.com>
+
+ * symfile.c (place_section): Remove "struct" from section_addr_info
+ in comment.
+ * windows-nat.c (struct safe_symbol_file_add_args) <addrs>: Likewise.
+
2018-03-23 Keith Seitz <keiths@redhat.com>
PR c++/22968
diff --git a/gdb/symfile.c b/gdb/symfile.c
index 9571664776..1e5297ee29 100644
--- a/gdb/symfile.c
+++ b/gdb/symfile.c
@@ -412,7 +412,7 @@ place_section (bfd *abfd, asection *sect, void *obj)
arg->lowest = start_addr + bfd_get_section_size (sect);
}
-/* Store struct section_addr_info as prepared (made relative and with SECTINDEX
+/* Store section_addr_info as prepared (made relative and with SECTINDEX
filled-in) by addr_info_make_relative into SECTION_OFFSETS of NUM_SECTIONS
entries. */
diff --git a/gdb/windows-nat.c b/gdb/windows-nat.c
index f849f1f322..430cc60993 100644
--- a/gdb/windows-nat.c
+++ b/gdb/windows-nat.c
@@ -579,7 +579,7 @@ struct safe_symbol_file_add_args
{
char *name;
int from_tty;
- struct section_addr_info *addrs;
+ section_addr_info *addrs;
int mainline;
int flags;
struct ui_file *err, *out;
--
2.13.6
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Remove struct keyword from section_addr_info
2018-03-23 20:36 [PATCH] Remove struct keyword from section_addr_info Keith Seitz
@ 2018-03-24 2:46 ` Simon Marchi
2018-03-26 17:39 ` Keith Seitz
0 siblings, 1 reply; 3+ messages in thread
From: Simon Marchi @ 2018-03-24 2:46 UTC (permalink / raw)
To: Keith Seitz, gdb-patches
On 2018-03-23 04:36 PM, Keith Seitz wrote:
> Buildbot pointed out a failiure in windows-nat.c:
>
> ../../binutils-gdb/gdb/windows-nat.c:582:10: error: using typedef-name 'section_addr_info' after 'struct'
> struct section_addr_info *addrs;
> ^~~~~~~~~~~~~~~~~
> In file included from ../../binutils-gdb/gdb/windows-nat.c:49:0:
> ../../binutils-gdb/gdb/symfile.h:75:37: note: 'section_addr_info' has a previous declaration here
> typedef std::vector<other_sections> section_addr_info;
> ^~~~~~~~~~~~~~~~~
>
> A recursive grep of the sources for "struct section_addr_info" reveals one
> additional reference in a comment. In both cases, this patch simply removes
> the struct keyword.
>
> gdb/ChangeLog:
>
> * symfile.c (place_section): Remove "struct" from section_addr_info
> in comment.
> * windows-nat.c (struct safe_symbol_file_add_args) <addrs>: Likewise.
The "Likewise" is not really accurate, since the second entry isn't changing
a comment like the first one. But otherwise LGTM (I would have considered it
as pretty obvious).
Simon
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Remove struct keyword from section_addr_info
2018-03-24 2:46 ` Simon Marchi
@ 2018-03-26 17:39 ` Keith Seitz
0 siblings, 0 replies; 3+ messages in thread
From: Keith Seitz @ 2018-03-26 17:39 UTC (permalink / raw)
To: gdb-patches
On 03/23/2018 07:45 PM, Simon Marchi wrote:
>> * symfile.c (place_section): Remove "struct" from section_addr_info
>> in comment.
>> * windows-nat.c (struct safe_symbol_file_add_args) <addrs>: Likewise.
>
> The "Likewise" is not really accurate, since the second entry isn't changing
> a comment like the first one. But otherwise LGTM (I would have considered it
> as pretty obvious).
Bah, I can't believe I did that. I've edited the ChangeLog and pushed the patch.
Keith
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-03-26 17:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-23 20:36 [PATCH] Remove struct keyword from section_addr_info Keith Seitz
2018-03-24 2:46 ` Simon Marchi
2018-03-26 17:39 ` Keith Seitz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).