From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id AB962385C426 for ; Sat, 23 May 2020 21:24:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org AB962385C426 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 04NLOU2o006872 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 23 May 2020 17:24:35 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 04NLOU2o006872 Received: from [10.0.0.11] (173-246-6-90.qc.cable.ebox.net [173.246.6.90]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 6ACDE1E072; Sat, 23 May 2020 17:24:30 -0400 (EDT) Subject: Re: Pushed to gdb-9-branch: [PUSHED/OBVIOUS] Fix base class function call To: Joel Brobecker , Christian Biesinger via gdb-patches References: <20200205175257.197506-1-cbiesinger@google.com> <20200523163130.GA2122@adacore.com> From: Simon Marchi Message-ID: <5933af77-3e14-7ab5-5f9a-35146a3d2b15@polymtl.ca> Date: Sat, 23 May 2020 17:24:29 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <20200523163130.GA2122@adacore.com> Content-Type: text/plain; charset=utf-8 Content-Language: fr Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Sat, 23 May 2020 21:24:30 +0000 X-Spam-Status: No, score=-3.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 23 May 2020 21:24:41 -0000 On 2020-05-23 12:31 p.m., Joel Brobecker wrote: > Hi Christian (and Simon), > > On Wed, Feb 05, 2020 at 11:52:57AM -0600, Christian Biesinger via gdb-patches wrote: >> This was a typo introduced in f6ac5f3d63e03a81c4ff3749aba234961cc9090e. >> >> Found by looking through NetBSD's GDB patches: >> https://github.com/NetBSD/pkgsrc-wip/blob/master/gdb-netbsd/patches/patch-gdb_sparc-nat.h >> >> This patch can't be tested on Linux because Linux does not use the >> sparc_target template. >> >> gdb/ChangeLog: >> >> 2020-02-05 Christian Biesinger >> >> * sparc-nat.h (struct sparc_target) : Fix base class >> function call. > > As a user stumbled onto the error that this commit fixes, and the correction > is indeed quite obvious, I created a new PR for this issue, and then > backported the patch to the gdb-9-branch: > > https://sourceware.org/bugzilla/show_bug.cgi?id=26029 Good thing you were proactive, otherwise it wouldn't have made it in the 9.2 release! Simon