From: Andrew Burgess <andrew.burgess@embecosm.com>
To: gdb-patches@sourceware.org
Subject: [PATCH 06/11] sim/rx: use puts instead of printf in a few places
Date: Mon, 1 Feb 2021 11:44:09 +0000 [thread overview]
Message-ID: <594cd64926e070920c8860baa08e9e55f0c7c9c3.1612179773.git.andrew.burgess@embecosm.com> (raw)
In-Reply-To: <cover.1612179773.git.andrew.burgess@embecosm.com>
Calling printf with the format being a non constant string results in
a GCC warning. Use puts instead in a few places.
sim/rx/ChangeLog:
* reg.c (fpsw2str): Replace use of printf with puts.
(trace_register_changes): Likewise.
---
sim/rx/ChangeLog | 5 +++++
sim/rx/reg.c | 8 ++++----
2 files changed, 9 insertions(+), 4 deletions(-)
diff --git a/sim/rx/reg.c b/sim/rx/reg.c
index 00796a0c99a..f1bdd4c9841 100644
--- a/sim/rx/reg.c
+++ b/sim/rx/reg.c
@@ -509,7 +509,7 @@ fpsw2str(int rpsw)
#define TRC(f,n) \
if (oldregs.f != regs.f) \
{ \
- if (tag) { printf (tag); tag = 0; } \
+ if (tag) { puts (tag); tag = 0; } \
printf(" %s %08x:%08x", n, \
(unsigned int)oldregs.f, \
(unsigned int)regs.f); \
@@ -531,7 +531,7 @@ trace_register_changes (void)
TRC (r_isp, "isp");
if (oldregs.r_psw != regs.r_psw)
{
- if (tag) { printf (tag); tag = 0; }
+ if (tag) { puts (tag); tag = 0; }
printf(" psw %s:", psw2str(oldregs.r_psw));
printf("%s", psw2str(regs.r_psw));
oldregs.r_psw = regs.r_psw;
@@ -539,7 +539,7 @@ trace_register_changes (void)
if (oldregs.r_fpsw != regs.r_fpsw)
{
- if (tag) { printf (tag); tag = 0; }
+ if (tag) { puts (tag); tag = 0; }
printf(" fpsw %s:", fpsw2str(oldregs.r_fpsw));
printf("%s", fpsw2str(regs.r_fpsw));
oldregs.r_fpsw = regs.r_fpsw;
@@ -547,9 +547,9 @@ trace_register_changes (void)
if (oldregs.r_acc != regs.r_acc)
{
- if (tag) { printf (tag); tag = 0; }
printf(" acc %016llx:", oldregs.r_acc);
printf("%016llx", regs.r_acc);
+ if (tag) { puts (tag); tag = 0; }
oldregs.r_acc = regs.r_acc;
}
--
2.25.4
next prev parent reply other threads:[~2021-02-01 11:44 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-01 11:44 [PATCH 00/11] fix build warnings for rx simulator Andrew Burgess
2021-02-01 11:44 ` [PATCH 01/11] sim/rx: define sim_memory_map Andrew Burgess
2021-02-01 14:46 ` Mike Frysinger
2021-02-08 11:01 ` Andrew Burgess
2021-02-01 11:44 ` [PATCH 02/11] sim/rx: fix an issue where we try to modify a const string Andrew Burgess
2021-02-01 11:44 ` [PATCH 03/11] sim/rx: fill in missing 'void' for empty argument lists Andrew Burgess
2021-02-01 11:44 ` [PATCH 04/11] sim/rx: mark some functions as static Andrew Burgess
2021-02-01 11:44 ` [PATCH 05/11] sim/rx: delete an unused function Andrew Burgess
2021-02-01 11:44 ` Andrew Burgess [this message]
2021-02-01 14:49 ` [PATCH 06/11] sim/rx: use puts instead of printf in a few places Mike Frysinger
2021-02-08 10:58 ` Andrew Burgess
2021-02-01 11:44 ` [PATCH 07/11] sim/rx: move some variable declarations to the start of the block Andrew Burgess
2021-02-01 11:44 ` [PATCH 08/11] sim/rx: use PRIx64 in printf format string Andrew Burgess
2021-02-01 11:44 ` [PATCH 09/11] sim/rx: add some missing includes Andrew Burgess
2021-02-01 11:44 ` [PATCH 10/11] sim/rx: avoid pointer arithmetic on void * pointers Andrew Burgess
2021-02-01 11:44 ` [PATCH 11/11] sim/rx: enable build with warnings Andrew Burgess
2021-02-01 14:50 ` Mike Frysinger
2021-02-02 4:53 ` [PATCH] sim: erc32/m32c/rl78: add sim_memory_map stub for gdb Mike Frysinger
2021-02-08 10:57 ` [PATCH 11/11] sim/rx: enable build with warnings Andrew Burgess
2021-02-02 4:37 ` [PATCH 00/11] fix build warnings for rx simulator Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=594cd64926e070920c8860baa08e9e55f0c7c9c3.1612179773.git.andrew.burgess@embecosm.com \
--to=andrew.burgess@embecosm.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).