From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <simark@simark.ca>
Received: from simark.ca (simark.ca [158.69.221.121])
 by sourceware.org (Postfix) with ESMTPS id 532B13856DE8
 for <gdb-patches@sourceware.org>; Thu, 28 Jul 2022 14:30:58 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 532B13856DE8
Received: from [172.16.0.95] (192-222-180-24.qc.cable.ebox.net
 [192.222.180.24])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested)
 by simark.ca (Postfix) with ESMTPSA id 918191E9E9;
 Thu, 28 Jul 2022 10:30:57 -0400 (EDT)
Message-ID: <595494b6-f56e-f354-cb2a-b9fd035f4bdb@simark.ca>
Date: Thu, 28 Jul 2022 10:30:57 -0400
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH] use return instead of continue to avoid shellcheck error
Content-Language: fr
To: yaowenbin <yaowenbin1@huawei.com>, gdb-patches@sourceware.org
Cc: "hewenliang (C)" <hewenliang4@huawei.com>, linfeilong@huawei.com
References: <375f9654-9c01-6bd3-7134-6865f49b69eb@huawei.com>
From: Simon Marchi <simark@simark.ca>
In-Reply-To: <375f9654-9c01-6bd3-7134-6865f49b69eb@huawei.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-Spam-Status: No, score=-11.4 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A,
 SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Thu, 28 Jul 2022 14:30:59 -0000

On 7/28/22 05:22, yaowenbin via Gdb-patches wrote:
> Signed-off-by: yaowenbin<yaowenbin1@huawei.com>
> ---
>  gdb/gdb_mbuild.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/gdb/gdb_mbuild.sh b/gdb/gdb_mbuild.sh
> index 47403a7..51d2853 100755
> --- a/gdb/gdb_mbuild.sh
> +++ b/gdb/gdb_mbuild.sh
> @@ -171,7 +171,7 @@ fail ()
>  	if test "${keepgoing}" != ""
>  	then
>  	    #exit 1
> -	    continue
> +	    return 1
>  	else
>  	    kill $$
>  	    exit 1
> -- 
> 2.23.0

Thanks, that seems quite obvious to me.  I pushed the patch with the commit
message amended to put the shellcheck error message.

Simon