From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) by sourceware.org (Postfix) with ESMTPS id B8C023858D37 for ; Sat, 7 Oct 2023 08:37:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B8C023858D37 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 73DE41F896; Sat, 7 Oct 2023 08:37:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1696667845; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=17ss1yZ0Oz8xhE9CsTGscDeWTS9lKZmdFLVvMmXmngE=; b=LIOuB12GnLUJo1kihtQ9ezEVrEv2Ckh/rjh8uxn0iPMLPgGFWxzaRBjiTllNVxMX/uBG/j ugGa1js0bfiMwejQ7XN+6F0RBIE2MU06wrtrUXYAIU4C3LyASmrIAcfyeilgvsAyid/smY 2tVZETMNNWD8CesHJ8KaguyJme/X6R0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1696667845; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=17ss1yZ0Oz8xhE9CsTGscDeWTS9lKZmdFLVvMmXmngE=; b=Iq9FDClTjQUrc4laWqLN2FYsmjZsMAk3TWwUNRFACcYYCJSNp7Sku/RUBkf2DpTFBkzEjj NtHhe4emqagT0KBg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 4CE7E1391E; Sat, 7 Oct 2023 08:37:25 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 9/uZEcUYIWWcEwAAMHmgww (envelope-from ); Sat, 07 Oct 2023 08:37:25 +0000 Message-ID: <5960f945-4677-49a8-8a51-38e0e0d4fd6c@suse.de> Date: Sat, 7 Oct 2023 10:37:28 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] [gdb/testsuite] Fix gdb.arch/i386-signal.exp on x86_64 Content-Language: en-US To: John Baldwin , gdb-patches@sourceware.org Cc: Jan Beulich References: <20231001111450.2719-1-tdevries@suse.de> <38ed3f1d-847e-dc56-18d2-b98309c0a4b1@FreeBSD.org> From: Tom de Vries In-Reply-To: <38ed3f1d-847e-dc56-18d2-b98309c0a4b1@FreeBSD.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-10.2 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,KAM_NUMSUBJECT,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 10/7/23 00:06, John Baldwin wrote: > On 10/1/23 7:14 AM, Tom de Vries via Gdb-patches wrote: >> On x86_64-linux, with test-case gdb.arch/i386-signal.exp I run into: >> ... >> builtin_spawn -ignore SIGHUP gcc -fno-stack-protector i386-signal.c \ >>    -fdiagnostics-color=never -fno-pie -g -no-pie -lm -o i386-signal^M >> /tmp/cc2xydTG.s: Assembler messages:^M >> /tmp/cc2xydTG.s:50: Error: operand size mismatch for `push'^M >> compiler exited with status 1 >> output is: >> /tmp/cc2xydTG.s: Assembler messages:^M >> /tmp/cc2xydTG.s:50: Error: operand size mismatch for `push'^M >> >> gdb compile failed, /tmp/cc2xydTG.s: Assembler messages: >> /tmp/cc2xydTG.s:50: Error: operand size mismatch for `push' >> UNTESTED: gdb.arch/i386-signal.exp: failed to compile >> ... >> >> This is with gas 2.41, it compiles without problems with gas 2.40. >> Some more >> strict checking was added in commit 5cc007751cd ("x86: further adjust >> extend-to-32bit-address conditions"). >> >> The offending bit is: >> ... >>      "    push $sigframe\n" >> ... >> which refers to a function: >> ... >>      "    .globl sigframe\n" >>      "sigframe:\n" >> ... >> >> The test-case passes with target board unix/-m32. >> >> Make the test-case work by using pushq instead of push for the >> is_amd64_regs_target case. >> >> Tested on x86_64-linux, with target boards: >> - unix/-m64 (is_amd64_regs_target == 1), and >> - unix/-m32 (is_amd64_regs_target == 0), >> >> PR testsuite/30928 >> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=30928 >> --- >>   gdb/testsuite/gdb.arch/i386-signal.c   | 4 ++++ >>   gdb/testsuite/gdb.arch/i386-signal.exp | 7 ++++++- >>   2 files changed, 10 insertions(+), 1 deletion(-) >> >> diff --git a/gdb/testsuite/gdb.arch/i386-signal.c >> b/gdb/testsuite/gdb.arch/i386-signal.c >> index 19bb1bbaaf8..4bf97e5f159 100644 >> --- a/gdb/testsuite/gdb.arch/i386-signal.c >> +++ b/gdb/testsuite/gdb.arch/i386-signal.c >> @@ -45,7 +45,11 @@ asm(".text\n" >>       "    .align 8\n" >>       "    .globl setup\n" >>       "setup:\n" >> +#if IS_AMD64_REGS_TARGET >> +    "    pushq $sigframe\n" >> +#else >>       "    push $sigframe\n" >> +#endif >>       "    jmp func\n" >>       "\n" >>       "    .cfi_startproc\n" >> diff --git a/gdb/testsuite/gdb.arch/i386-signal.exp >> b/gdb/testsuite/gdb.arch/i386-signal.exp >> index f6a88719a40..a69172ed5cb 100644 >> --- a/gdb/testsuite/gdb.arch/i386-signal.exp >> +++ b/gdb/testsuite/gdb.arch/i386-signal.exp >> @@ -19,8 +19,13 @@ require {is_any_target "i?86-*-*" "x86_64-*-*"} >>   standard_testfile >> +set opts {} >> +lappend opts debug >> +lappend opts nopie >> +lappend opts >> additional_flags=-DIS_AMD64_REGS_TARGET=[is_amd64_regs_target] >> + >>   if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" \ >> -      executable { debug nopie }] != "" } { >> +      executable $opts] != "" } { >>       untested "failed to compile" >>       return -1 >>   } >> >> base-commit: 23b5268986d9b68b965939416a7aa96e8698e403 > > LGRM > Thanks for the review. I've committed after adding a note about https://sourceware.org/pipermail/binutils/2023-October/129818.html to the commit log. Thanks, - Tom