From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 88305 invoked by alias); 21 Dec 2017 02:40:40 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 88295 invoked by uid 89); 21 Dec 2017 02:40:40 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy= X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 21 Dec 2017 02:40:38 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id vBL2eVR0021164 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 20 Dec 2017 21:40:36 -0500 Received: by simark.ca (Postfix, from userid 112) id A86651E59F; Wed, 20 Dec 2017 21:40:31 -0500 (EST) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id 5DED21E4C4; Wed, 20 Dec 2017 21:40:10 -0500 (EST) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Thu, 21 Dec 2017 02:40:00 -0000 From: Simon Marchi To: Eli Zaretskii Cc: Stafford Horne , gdb-patches@sourceware.org, openrisc@lists.librecores.org Subject: Re: [PATCH v3 1/4] reggroups: Add test and docs for `info reg $reggroup` feature In-Reply-To: <837etiptz2.fsf@gnu.org> References: <20171219142257.13402-1-shorne@gmail.com> <20171219142257.13402-2-shorne@gmail.com> <837etiptz2.fsf@gnu.org> Message-ID: <596161e11663add8b95ca70dd1f8f12b@polymtl.ca> X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.3.2 X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Thu, 21 Dec 2017 02:40:31 +0000 X-IsSubscribed: yes X-SW-Source: 2017-12/txt/msg00460.txt.bz2 On 2017-12-19 11:23, Eli Zaretskii wrote: >> From: Stafford Horne >> Cc: Openrisc , Stafford Horne >> >> Date: Tue, 19 Dec 2017 23:22:54 +0900 >> >> Until now this feature has existed but was not documented. Adding >> docs >> and tests. > > Thanks! > >> +@item info registers @var{reggroup} @dots{} >> +Print the name and value of the registers in each of the specified >> +@var{reggroup}. The @var{reggoup} can be any of those returned by > > Please use "@var{reggroup}s", with the trailing "s", otherwise this is > not correct English. > >> +@code{maint print reggroups}. > > Please add here a cross-reference to the node where "maint print > reggroups" is described. Is it ok for a non-maint command to refer to a maint command? AFAIK, we don't expect an average user to have to use maintenance commands when using GDB. So maybe "maint print reggroups" should be promoted to a non-maint command (e.g. info register-groups)? Simon