From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 101504 invoked by alias); 19 Oct 2017 17:37:20 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 101495 invoked by uid 89); 19 Oct 2017 17:37:20 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=forgot X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 19 Oct 2017 17:37:19 +0000 Received: from svr-orw-mbx-03.mgc.mentorg.com ([147.34.90.203]) by relay1.mentorg.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-SHA384:256) id 1e5Ekv-00068h-RH from Sandra_Loosemore@mentor.com ; Thu, 19 Oct 2017 10:37:17 -0700 Received: from [127.0.0.1] (147.34.91.1) by svr-orw-mbx-03.mgc.mentorg.com (147.34.90.203) with Microsoft SMTP Server (TLS) id 15.0.1263.5; Thu, 19 Oct 2017 10:37:15 -0700 Subject: Re: [PATCH] Fix PR 8841 for nios2-linux To: Yao Qi , References: <1508154626-389-1-git-send-email-yao.qi@linaro.org> From: Sandra Loosemore Message-ID: <59E8E2CA.5030906@codesourcery.com> Date: Thu, 19 Oct 2017 17:37:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <1508154626-389-1-git-send-email-yao.qi@linaro.org> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SVR-ORW-MBX-06.mgc.mentorg.com (147.34.90.206) To svr-orw-mbx-03.mgc.mentorg.com (147.34.90.203) X-SW-Source: 2017-10/txt/msg00637.txt.bz2 On 10/16/2017 05:50 AM, Yao Qi wrote: > This patch is to use gdbarch method code_of_frame_writable, to skip > signal trampoline frame for breakpoint setting on nios2-linux. The patch > was written last year, but forgot to upstream it. > > I don't have the env to test this patch, so Sandra could you try this > patch? > > gdb: > > 2017-10-16 Yao Qi > > PR gdb/8841 > * nios2-linux-tdep.c (nios2_linux_code_of_frame_writable): New > function. > (nios2_linux_init_abi): Install gdbarch code_of_frame_writable. Thanks for looking at this! :-) The patch does seem to have the intended behavior for "finish", but there are multiple new FAILs in the test case sigaltstack.exp, which hasn't been adjusted to know that it's valid for "finish" to skip frames. Plus that test has KFAILs for the existing behavior of being unable to set the breakpoint at an unwritable address that ought to be removed, too. It also looks like this fix doesn't work for "step" out of a signal handler -- this shows up in sigstep.exp. And there are new FAILs in that testcase where "finish" is doing unexpected things now too. -Sandra