[committed][gdb/testsuite] Fix language in dw2-bad-mips-linkage-name.exp

[Tom de Vries <tdevries@suse.de>]

[-- Attachment #1: Type: text/plain, Size: 847 bytes --]

[ was: Re: [PATCH 08/10] Use the linkage name if it exists ]
On 24-04-2020 22:50, Tom Tromey wrote:
>>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:
> 
> Tom> Hmm, one thing that is odd about this test-case is that it constructs a
> Tom> C language CU, which contains a subprogram with DW_AT_MIPS_linkage_name
> Tom> attribute with a C++ mangled name.
> 
> This sounds very familiar.  I feel like I patched this at some point but
> now I don't know where that patch went.
> 
> Tom> If I update the testcase to use a c++ language CU, the test passes:
> 
> I think this is the correct thing to do.
> The main point of the test is to ensure that the linkage name with the
> wrong form doesn't cause a crash:
> 
> 		{DW_AT_MIPS_linkage_name 42 DW_FORM_data1}
> 
> I suggest you check this in.

Ack, committed as attached below.

Thanks,
- Tom


[-- Attachment #2: 0001-gdb-testsuite-Fix-language-in-dw2-bad-mips-linkage-name.exp.patch --]
[-- Type: text/x-patch, Size: 1494 bytes --]

[gdb/testsuite] Fix language in dw2-bad-mips-linkage-name.exp

The test-case gdb.dwarf2/dw2-bad-mips-linkage-name.exp has a CU with
language C, which contains a subprogram with a C++-mangled name as its
DW_AT_mips_linkage_name attribute.

Fix this by changing the language of the CU to C++.

Tested on x86_64-linux.

gdb/testsuite/ChangeLog:

2020-04-24  Tom de Vries  <tdevries@suse.de>

	* gdb.dwarf2/dw2-bad-mips-linkage-name.exp: Set language of CU to
	C++.

---
 gdb/testsuite/gdb.dwarf2/dw2-bad-mips-linkage-name.exp | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/gdb/testsuite/gdb.dwarf2/dw2-bad-mips-linkage-name.exp b/gdb/testsuite/gdb.dwarf2/dw2-bad-mips-linkage-name.exp
index d00308a5702..5f01c41aaa3 100644
--- a/gdb/testsuite/gdb.dwarf2/dw2-bad-mips-linkage-name.exp
+++ b/gdb/testsuite/gdb.dwarf2/dw2-bad-mips-linkage-name.exp
@@ -38,7 +38,7 @@ Dwarf::assemble $asm_file {
 
     cu {} {
 	DW_TAG_compile_unit {
-                {DW_AT_language @DW_LANG_C}
+                {DW_AT_language @DW_LANG_C_plus_plus}
                 {DW_AT_name     dw2-bad-mips-linkage-name.c}
                 {DW_AT_comp_dir /tmp}
 
@@ -78,5 +78,5 @@ if { [prepare_for_testing "failed to prepare" ${testfile} \
 # much matter what we test here, so long as we do something to make
 # sure that the DWARF is read.
 
-gdb_test "ptype f" " = bool \\(\\)"
-gdb_test "ptype g" " = bool \\(\\)"
+gdb_test "ptype f" " = bool \\(void\\)"
+gdb_test "ptype g" " = bool \\(void\\)"