From: "Jan Beulich" <jbeulich@suse.com>
To: <simon.marchi@ericsson.com>,<simon.marchi@polymtl.ca>
Cc: <markus.t.metzger@intel.com>,<tim.wiederhake@intel.com>,
<gdb-patches@sourceware.org>
Subject: Re: [PATCH] x86-64: fix ZMM register state tracking
Date: Wed, 03 Oct 2018 14:30:00 -0000 [thread overview]
Message-ID: <5BB4D278020000780013F4F4@prv1-mh.provo.novell.com> (raw)
In-Reply-To: <580ba4ea-93ae-ffd0-7bce-bd1f75cf9ff9@ericsson.com>
>>> Simon Marchi <simon.marchi@ericsson.com> 10/02/18 9:20 PM >>>
>On 2018-09-25 11:04 AM, Jan Beulich wrote:
>>>>> On 25.09.18 at 05:28, <simon.marchi@ericsson.com> wrote:
>>> On 2018-09-18 09:37 AM, Jan Beulich wrote:
>>> Thanks for the instructions. There is already a test covering AVX512
>>> instructions, so I figured I would add it there. However, I don't
>>> have a processor that supports AVX512, so I'm unable to run the test.
>>>
>>> Here's a patch, can you try to confirm that the test fails without the
>>> fix and passes with the fix? I probably screwed up somewhere, but it
>>> should be pretty close.
>>
>> There are two issues here: First of all, unrelated to this patch, the
>> construct around line 95 in i386-avx512.exp should look like
>>
>> if [is_amd64_regs_target] {
>> set nr_regs 32
>> } else {
>> set nr_regs 8
>> }
>>
>> Of course this also affects other tests in here, but without this correction
>> the loop you add does nothing at all.
>
>Thanks, this has now been fixed in master.
Ah, good to know.
>Here's the revised version with this fixed. I am not sure about the output
>for zmm0 though.
I'll give this a go and adjust if need be, but it'll likely take me a couple of
days to get to it. I take it that ...
>--- a/gdb/testsuite/gdb.arch/i386-avx512.c
>+++ b/gdb/testsuite/gdb.arch/i386-avx512.c
>@@ -249,6 +249,13 @@ main (int argc, char **argv)
>move back to array and check values. */
>move_zmm_data_to_memory ();
>asm ("nop"); /* sixth breakpoint here */
>+
>+ asm ("vpternlogd $0xff, %zmm0, %zmm0, %zmm0");
>+#ifdef __x86_64__s
... the trailing s here simply is a typo.
Jan
next prev parent reply other threads:[~2018-10-03 14:30 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-05 13:23 Jan Beulich
2018-09-07 23:13 ` Simon Marchi
2018-09-10 6:25 ` Jan Beulich
2018-09-10 13:01 ` Simon Marchi
2018-09-18 13:38 ` Jan Beulich
2018-09-25 3:29 ` Simon Marchi
2018-09-25 15:04 ` Jan Beulich
2018-10-02 19:20 ` Simon Marchi
2018-10-03 14:30 ` Jan Beulich [this message]
2018-10-03 14:41 ` Simon Marchi
2018-09-11 10:34 ` Pedro Alves
2018-09-11 11:34 ` Jan Beulich
2018-09-24 17:19 ` Metzger, Markus T
2018-09-25 7:47 ` Jan Beulich
2018-10-10 15:12 ` [PATCH v2] " Jan Beulich
2018-10-29 10:31 ` Ping: " Jan Beulich
2018-10-31 14:00 ` Simon Marchi
2018-11-07 9:07 ` Metzger, Markus T
2018-11-07 9:12 ` Jan Beulich
2018-11-07 13:18 ` Metzger, Markus T
2018-11-07 13:25 ` Jan Beulich
2018-11-07 14:18 ` Simon Marchi
2018-11-08 11:16 ` Jan Beulich
2018-11-08 16:24 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5BB4D278020000780013F4F4@prv1-mh.provo.novell.com \
--to=jbeulich@suse.com \
--cc=gdb-patches@sourceware.org \
--cc=markus.t.metzger@intel.com \
--cc=simon.marchi@ericsson.com \
--cc=simon.marchi@polymtl.ca \
--cc=tim.wiederhake@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).