From: "Jan Beulich" <JBeulich@suse.com>
To: "Markus T Metzger" <markus.t.metzger@intel.com>
Cc: "Simon Marchi" <simon.marchi@polymtl.ca>,
"Pedro Alves" <palves@redhat.com>,"GDB"
<gdb-patches@sourceware.org>
Subject: RE: Ping: [PATCH v2] x86-64: fix ZMM register state tracking
Date: Wed, 07 Nov 2018 13:25:00 -0000 [thread overview]
Message-ID: <5BE2E7E002000078001F91C6@prv1-mh.provo.novell.com> (raw)
In-Reply-To: <A78C989F6D9628469189715575E55B236B38222C@IRSMSX104.ger.corp.intel.com>
>>> On 07.11.18 at 14:18, <markus.t.metzger@intel.com> wrote:
>> >>> On 07.11.18 at 10:07, <markus.t.metzger@intel.com> wrote:
>> >> On 2018-10-29 06:31, Jan Beulich wrote:
>> >> >>>> On 10.10.18 at 17:12, wrote:
>> >> >> The three AVX512 state components are entirely independent - one
>> >> >> being in its "init state" has no implication whatsoever on either
>> >> >> of the other two. Fully separate X86_XSTATE_ZMM_H and
>> >> >> X86_XSTATE_ZMM handling, to prevent upper halves of the upper 16
>> >> >> ZMM registers to display as if they were zero (when they aren't) after
> e.g.
>> >> >> VZEROALL/VZEROUPPER.
>> >> >>
>> >> >> gdb/
>> >> >> 2018-10-10 Jan Beulich <jbeulich@suse.com>
>> >> >>
>> >> >> * i387-tdep.c (i387_supply_xsave): Split handling of
>> >> >> X86_XSTATE_ZMM_H and X86_XSTATE_ZMM.
>> >> >> (i387_collect_xsave): Likewise.
>> >> >>
>> >> >> gdb/testsuite/
>> >> >> 2018-10-10 Simon Marchi <simon.marchi@polymtl.ca>
>> >> >>
>> >> >> * testsuite/gdb.arch/i386-avx512.c,
>> >> >> testsuite/gdb.arch/i386-avx512.exp: Add 7th test.
>> >> >>
>> >> >> ---
>> >> >> v2: Attach comments to zmm_endlo_regnum declarations. Add testcase
>> >> >> provided by Simon.
>> >>
>> >> The testcase obviously LGTM. I will let Markus approve the other changes.
>> >
>> > The code already looked good to me in v1. Thanks for adding comments.
>>
>> So can I translate this into an ack for me to commit the change?
>> Or else, who would be the one to give the go-ahead?
>
> Simon can approve your patch.
>
> IIRC Pedro had a question regarding gdbserver. From a first look, it seems to get the
> feature bits right but does not distinguish 32-bit and 64-bit mode regarding the number
> of available registers.
If there was a problem there, it was my understanding that this can
(and should) be fixed in a separate patch, by someone able to test
this.
> Did you run the new test you added also in remote configuration?
No, and I also have no idea how I would go about doing so.
Jan
next prev parent reply other threads:[~2018-11-07 13:25 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-05 13:23 [PATCH] " Jan Beulich
2018-09-07 23:13 ` Simon Marchi
2018-09-10 6:25 ` Jan Beulich
2018-09-10 13:01 ` Simon Marchi
2018-09-18 13:38 ` Jan Beulich
2018-09-25 3:29 ` Simon Marchi
2018-09-25 15:04 ` Jan Beulich
2018-10-02 19:20 ` Simon Marchi
2018-10-03 14:30 ` Jan Beulich
2018-10-03 14:41 ` Simon Marchi
2018-09-11 10:34 ` Pedro Alves
2018-09-11 11:34 ` Jan Beulich
2018-09-24 17:19 ` Metzger, Markus T
2018-09-25 7:47 ` Jan Beulich
2018-10-10 15:12 ` [PATCH v2] " Jan Beulich
2018-10-29 10:31 ` Ping: " Jan Beulich
2018-10-31 14:00 ` Simon Marchi
2018-11-07 9:07 ` Metzger, Markus T
2018-11-07 9:12 ` Jan Beulich
2018-11-07 13:18 ` Metzger, Markus T
2018-11-07 13:25 ` Jan Beulich [this message]
2018-11-07 14:18 ` Simon Marchi
2018-11-08 11:16 ` Jan Beulich
2018-11-08 16:24 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5BE2E7E002000078001F91C6@prv1-mh.provo.novell.com \
--to=jbeulich@suse.com \
--cc=gdb-patches@sourceware.org \
--cc=markus.t.metzger@intel.com \
--cc=palves@redhat.com \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).