From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 62026 invoked by alias); 11 Oct 2017 12:27:06 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 61916 invoked by uid 89); 11 Oct 2017 12:27:06 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-6.4 required=5.0 tests=BAYES_00,GIT_PATCH_1,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM autolearn=ham version=3.3.2 spammy= X-HELO: mail-wm0-f45.google.com Received: from mail-wm0-f45.google.com (HELO mail-wm0-f45.google.com) (74.125.82.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 11 Oct 2017 12:27:04 +0000 Received: by mail-wm0-f45.google.com with SMTP id b189so4193677wmd.4 for ; Wed, 11 Oct 2017 05:27:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=1os7V6fz99BTfTz9oxtsPj+lvxHOUCl52xyWC+SjJB4=; b=czTsZQD7Pj0OKj7RDDTSd3bltwxCud84dKh/hvTVUBnaPRmlVv51F3ZEY59VLDybgw yETyPDv0IxTldODfhaYmeEYmtCb3ySf99K+hC0LQ4AGzuM7xBQcqmJuemzOrnDqDeOE4 x59HCEoc1baGlxK5SQtHhBMYyz3aaPBkltfWg/xpN0OcRa3235rrnsgFTBUndcLQZ8UQ md1pg8O1hATycl8VED0GUcE1j7ou1CsHUcvJzysBFlcLQQpdE6Tzl0lm7gsBbJOwh4wh niGui2h39xg2It+2kMDYzKNi1hbl9XKD4a4b0ma5FtLLesmuXgqLGTJ5Llwy/hcskuDA amFQ== X-Gm-Message-State: AMCzsaVEOnXlkqxC1786LdIV5IewmMXYYIvBjcnhz+/mtPYV3ADXeZdj A+saRzCDSwQUkPEghwxIUgFAeSXgH4o= X-Google-Smtp-Source: AOwi7QC7vqaj5O++UFptbsvkE51wpKqtHN/Da8u6kAH3JCGuCZZD5tUTXyygIQF7ZPLP36VuJp318A== X-Received: by 10.28.97.194 with SMTP id v185mr14835112wmb.117.1507724822069; Wed, 11 Oct 2017 05:27:02 -0700 (PDT) Received: from ?IPv6:2a02:c7f:ae6a:ed00:4685:ff:fe66:9f4? ([2a02:c7f:ae6a:ed00:4685:ff:fe66:9f4]) by smtp.gmail.com with ESMTPSA id v8sm9688055wrg.80.2017.10.11.05.27.00 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 11 Oct 2017 05:27:01 -0700 (PDT) Subject: Re: [python][patch] Python rbreak To: Eli Zaretskii Cc: gdb-patches@sourceware.org References: <83tvz5opev.fsf@gnu.org> From: Phil Muldoon Message-ID: <5a00098f-1dc8-7220-e8ae-73347097079c@redhat.com> Date: Wed, 11 Oct 2017 12:27:00 -0000 MIME-Version: 1.0 In-Reply-To: <83tvz5opev.fsf@gnu.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2017-10/txt/msg00285.txt.bz2 On 11/10/17 13:11, Eli Zaretskii wrote: >> From: Phil Muldoon >> Date: Wed, 11 Oct 2017 12:30:17 +0100 >> >> 2017-10-11 Phil Muldoon >> >> * python.texi (Basic Python): Add rbreak documentation. > > This should go into a separate gdb/doc/ChangeLog file. It is locally. Not sure why the relative paths were not included. Anyway, noted and it will be in the doc/ ChangeLog. > >> +@findex gdb.rbreak >> +@defun gdb.rbreak (regex @r{[}, minisyms @r{[}, throttle, @r{[}, symtabs @r{]]]}) > > You don't need that @findex, since @defun automatically inserts the > function into the function index. Thanks. > The documentation part is okay with this fixed, but I think we also > want a NEWS entry. I'll add a NEWS entry and repost the doc part of the patch. Cheers Phil