From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-f44.google.com (mail-ed1-f44.google.com [209.85.208.44]) by sourceware.org (Postfix) with ESMTPS id 752FC3858C5E for ; Thu, 12 Oct 2023 17:30:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 752FC3858C5E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ed1-f44.google.com with SMTP id 4fb4d7f45d1cf-53b8f8c6b1fso2220781a12.0 for ; Thu, 12 Oct 2023 10:30:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697131829; x=1697736629; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=gpgfWhrPgzJPvBdvjxJWDv8nlwDGXejGU2yzuUsLlN0=; b=n99KcVEG6SkHtOagh8TJnxvrBM0LwQ46kebSOaHc3sGYUt9Cnye/qy2vtKETf+smAw O3rJraGA8/XoLbhcCFlovdSIs8KMj6UBzir/GDLnWi5LunKvvJUcHjM+tkPYCuDeTGML tmPJ8pgs+c1HZupu8BEQ1G0pRu5TIQisi6bRK2c6+ziHTbWQ4NKsDh4CQKGixc11EY28 +1oyt0pQ39l2z1ZDrwWVYXEkWEjVlu1gc3Ot7kSmcwV2aDM55bG59bdX7+zrdxBdSzan 6pLPKPu9h+9QhWEXQkwkag25j0D5JsFEMyavek3f0AldCbu0GWjCHg6vlLNX6vOhnb7N tupA== X-Gm-Message-State: AOJu0YzeCj1j8tCGYVaxNH09xYFEzjIp15kCTPJsigdB93vdHRkZ+Lwv FIKUQuWE19dlFzT+VKovV3Q= X-Google-Smtp-Source: AGHT+IH5XCCkeU0B3gUfUanqTsSNAM5sMCXulf1DQ7M6xJl56k0F9r3cTSycYDQsWPuaRWi5W+s/iw== X-Received: by 2002:a17:906:d3:b0:9b2:d64a:9ecd with SMTP id 19-20020a17090600d300b009b2d64a9ecdmr21910125eji.66.1697131829210; Thu, 12 Oct 2023 10:30:29 -0700 (PDT) Received: from ?IPV6:2001:8a0:f939:d200:dedd:c263:b7d3:9ba1? ([2001:8a0:f939:d200:dedd:c263:b7d3:9ba1]) by smtp.gmail.com with ESMTPSA id u25-20020a1709063b9900b0099bc2d1429csm11361088ejf.72.2023.10.12.10.30.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 12 Oct 2023 10:30:28 -0700 (PDT) Message-ID: <5a253bff-8e20-443c-9f7c-0bdc8d7c0841@palves.net> Date: Thu, 12 Oct 2023 18:30:14 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC] Require c++17 compiler Content-Language: en-US To: Lancelot SIX , Tom de Vries Cc: gdb-patches@sourceware.org References: <20231005065449.32643-1-tdevries@suse.de> <20231005103354.5loeki67slszfrcy@hpe6u-23> From: Pedro Alves In-Reply-To: <20231005103354.5loeki67slszfrcy@hpe6u-23> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3.4 required=5.0 tests=BAYES_00,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2023-10-05 11:33, Lancelot SIX via Gdb-patches wrote: > Hi Tom, > > Thanks for putting this together! As you know, I am in favor of such > change (for GDB-15 probably, GDB-14 branching is probably too close)! > > I do have a really similar patch available on a local branch. One > difference though is that my branch uses a preparatory patch to upgrade > gdb/ax_cxx_compile_stdcxx.m4 to follow upstream changes to this file. > This upgrade gives some improvements in the C++17 compiler detection. > We keep this in the GDB tree because it has some local changes to set > CXX_DIALECT. This preparatory patch should be included in this reply. > (As discussed at the Cauldron,) I agree it would be nice to do that, either before or after the C++17 requirement change. Your attached patch looks fine to me.