public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Tom de Vries <tdevries@suse.de>
To: Tom Tromey <tom@tromey.com>, Hannes Domani <ssbssa@yahoo.de>
Cc: Hannes Domani via Gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCHv2] Restore gdb.SYMBOL_STRUCT_DOMAIN constant
Date: Sun, 6 Jun 2021 00:36:32 +0200	[thread overview]
Message-ID: <5a314e1b-4cc7-af38-81e9-df4e37e793a8@suse.de> (raw)
In-Reply-To: <8735tw1kjv.fsf@tromey.com>

On 6/5/21 3:57 PM, Tom Tromey wrote:
>>>>>> "Hannes" == Hannes Domani <ssbssa@yahoo.de> writes:
> 
> Hannes> Sorry about that.
> Hannes> I'm gonna push the below as obvious.
> 
> Thank you.  It's an easy error to make :)
> 

Indeed, it is :)

Maybe easy enough to warn about in gdb_test_multiple:
...
    if { [regexp -line {python print +[^(]} $command] } {
        warning [concat \
                     "Missing parentheses in python print command," \
                     " will fail with python3"]
    }
...
?

Or, even correct automatically:
...

    if { [regexp -line {python print +[^(]} $command] } {
        set command [regsub {python print (.*)} $command \
                         {python print (\1)}]
    }
...
?

Thanks,
- Tom

  reply	other threads:[~2021-06-05 22:36 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20210526170536.657-1-ssbssa.ref@yahoo.de>
2021-05-26 17:05 ` Hannes Domani
2021-05-26 18:13   ` Andreas Schwab
2021-05-26 18:19     ` Hannes Domani
2021-05-29  3:19   ` Simon Marchi
2021-06-02 18:39   ` Tom Tromey
2021-06-03 13:00     ` Hannes Domani
2021-06-05 12:27       ` Tom de Vries
2021-06-05 12:43         ` Hannes Domani
2021-06-05 13:57           ` Tom Tromey
2021-06-05 22:36             ` Tom de Vries [this message]
2021-06-10 18:48               ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5a314e1b-4cc7-af38-81e9-df4e37e793a8@suse.de \
    --to=tdevries@suse.de \
    --cc=gdb-patches@sourceware.org \
    --cc=ssbssa@yahoo.de \
    --cc=tom@tromey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).