From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by sourceware.org (Postfix) with ESMTPS id 7F8F33857C67 for ; Sat, 5 Jun 2021 22:36:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7F8F33857C67 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de Received: from imap.suse.de (imap-alt.suse-dmz.suse.de [192.168.254.47]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 69FCB1FDB0; Sat, 5 Jun 2021 22:36:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1622932593; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PNkpILZxlFW7NjCII9qovxcr2vLbcR3nG2MWZ2shtUM=; b=HGC72lO/NzBZneN0BAvrk8h/KUZtUCLxPcBmRnRAKn5hCTreYCSNvSbeLyO+tLTta3grPH 2aenqKePG3lJ6JxguiS6+GE+N338lhJib64JqNrNJKS02Dggm4yy6Ne5MArrVo0xpelh4B R/U43+CA2JMbsaX5v2PcZgdyz3BpJqA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1622932593; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PNkpILZxlFW7NjCII9qovxcr2vLbcR3nG2MWZ2shtUM=; b=ogQlPjat7Kjzl0S30K0x13lypBj0i2ycOZ6OQ9tH5iqiFIwKwv7Z2/l334lZFfvY53hnoy xdZ87gA+n/UKFIDQ== Received: from imap3-int (imap-alt.suse-dmz.suse.de [192.168.254.47]) by imap.suse.de (Postfix) with ESMTP id 3EFC3118DD; Sat, 5 Jun 2021 22:36:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1622932593; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PNkpILZxlFW7NjCII9qovxcr2vLbcR3nG2MWZ2shtUM=; b=HGC72lO/NzBZneN0BAvrk8h/KUZtUCLxPcBmRnRAKn5hCTreYCSNvSbeLyO+tLTta3grPH 2aenqKePG3lJ6JxguiS6+GE+N338lhJib64JqNrNJKS02Dggm4yy6Ne5MArrVo0xpelh4B R/U43+CA2JMbsaX5v2PcZgdyz3BpJqA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1622932593; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PNkpILZxlFW7NjCII9qovxcr2vLbcR3nG2MWZ2shtUM=; b=ogQlPjat7Kjzl0S30K0x13lypBj0i2ycOZ6OQ9tH5iqiFIwKwv7Z2/l334lZFfvY53hnoy xdZ87gA+n/UKFIDQ== Received: from director2.suse.de ([192.168.254.72]) by imap3-int with ESMTPSA id vcaiDXH8u2D8aQAALh3uQQ (envelope-from ); Sat, 05 Jun 2021 22:36:33 +0000 Subject: Re: [PATCHv2] Restore gdb.SYMBOL_STRUCT_DOMAIN constant To: Tom Tromey , Hannes Domani Cc: Hannes Domani via Gdb-patches References: <20210526170536.657-1-ssbssa.ref@yahoo.de> <20210526170536.657-1-ssbssa@yahoo.de> <87k0ncp0v4.fsf@tromey.com> <2129329660.4623528.1622725230456@mail.yahoo.com> <6f5127bc-9967-4b17-b851-2f14276e3b5e@suse.de> <259660019.5490657.1622896987146@mail.yahoo.com> <8735tw1kjv.fsf@tromey.com> From: Tom de Vries Message-ID: <5a314e1b-4cc7-af38-81e9-df4e37e793a8@suse.de> Date: Sun, 6 Jun 2021 00:36:32 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.0 MIME-Version: 1.0 In-Reply-To: <8735tw1kjv.fsf@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, KAM_STOCKGEN, NICE_REPLY_A, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 05 Jun 2021 22:36:35 -0000 On 6/5/21 3:57 PM, Tom Tromey wrote: >>>>>> "Hannes" == Hannes Domani writes: > > Hannes> Sorry about that. > Hannes> I'm gonna push the below as obvious. > > Thank you. It's an easy error to make :) > Indeed, it is :) Maybe easy enough to warn about in gdb_test_multiple: ... if { [regexp -line {python print +[^(]} $command] } { warning [concat \ "Missing parentheses in python print command," \ " will fail with python3"] } ... ? Or, even correct automatically: ... if { [regexp -line {python print +[^(]} $command] } { set command [regsub {python print (.*)} $command \ {python print (\1)}] } ... ? Thanks, - Tom