From: Tom de Vries <tdevries@suse.de>
To: Simon Marchi <simon.marchi@polymtl.ca>, gdb-patches@sourceware.org
Subject: Re: [PATCH][gdb/testsuite] Fix gdb.dwarf2/fission-reread.exp with .gdb_index
Date: Tue, 2 Feb 2021 09:26:30 +0100 [thread overview]
Message-ID: <5a5925fa-f18b-3d70-253e-96c1774e9652@suse.de> (raw)
In-Reply-To: <07304c7c-e670-d2fe-19e1-e56ece7271b5@polymtl.ca>
On 2/1/21 5:24 PM, Simon Marchi wrote:
> I got these when applying the patch:
>
> Applying: Fix gdb.dwarf2/fission-reread.exp with .gdb_index
> .git/rebase-apply/patch:24: trailing whitespace.
>
> .git/rebase-apply/patch:179: trailing whitespace.
>
> .git/rebase-apply/patch:229: trailing whitespace.
> #define XSTR(s) STR(s)
> warning: 3 lines add whitespace errors.
>
> Can you hunt them down?
>
Ack, done.
[ And I've added this check to my git-format-patch.sh command. I was
under the impression that I got all the whitespace by looking at the git
diff output, but evidently not. ]
> Otherwise, LGTM.
Thanks, committed.
- Tom
prev parent reply other threads:[~2021-02-02 8:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-01 14:43 Tom de Vries
2021-02-01 16:24 ` Simon Marchi
2021-02-02 8:26 ` Tom de Vries [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5a5925fa-f18b-3d70-253e-96c1774e9652@suse.de \
--to=tdevries@suse.de \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).