From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tdevries@suse.de>
Received: from mx2.suse.de (mx2.suse.de [195.135.220.15])
 by sourceware.org (Postfix) with ESMTPS id 175B03857015
 for <gdb-patches@sourceware.org>; Tue,  2 Feb 2021 08:26:32 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 175B03857015
Authentication-Results: sourceware.org;
 dmarc=none (p=none dis=none) header.from=suse.de
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tdevries@suse.de
X-Virus-Scanned: by amavisd-new at test-mx.suse.de
Received: from relay2.suse.de (unknown [195.135.221.27])
 by mx2.suse.de (Postfix) with ESMTP id 3471BAD4E;
 Tue,  2 Feb 2021 08:26:31 +0000 (UTC)
Subject: Re: [PATCH][gdb/testsuite] Fix gdb.dwarf2/fission-reread.exp with
 .gdb_index
To: Simon Marchi <simon.marchi@polymtl.ca>, gdb-patches@sourceware.org
References: <20210201144335.GA1920@delia>
 <07304c7c-e670-d2fe-19e1-e56ece7271b5@polymtl.ca>
From: Tom de Vries <tdevries@suse.de>
Message-ID: <5a5925fa-f18b-3d70-253e-96c1774e9652@suse.de>
Date: Tue, 2 Feb 2021 09:26:30 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.6.1
MIME-Version: 1.0
In-Reply-To: <07304c7c-e670-d2fe-19e1-e56ece7271b5@polymtl.ca>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
X-Spam-Status: No, score=-6.4 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS,
 NICE_REPLY_A, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS,
 TXREP autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Tue, 02 Feb 2021 08:26:33 -0000

On 2/1/21 5:24 PM, Simon Marchi wrote:
> I got these when applying the patch:
> 
>     Applying: Fix gdb.dwarf2/fission-reread.exp with .gdb_index
>     .git/rebase-apply/patch:24: trailing whitespace.
> 
>     .git/rebase-apply/patch:179: trailing whitespace.
> 
>     .git/rebase-apply/patch:229: trailing whitespace.
>     #define XSTR(s) STR(s)
>     warning: 3 lines add whitespace errors.
> 
> Can you hunt them down?
> 

Ack, done.

[ And I've added this check to my git-format-patch.sh command.  I was
under the impression that I got all the whitespace by looking at the git
diff output, but evidently not. ]

> Otherwise, LGTM.

Thanks, committed.

- Tom