From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 99517 invoked by alias); 13 Jan 2020 15:10:14 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 99508 invoked by uid 89); 13 Jan 2020 15:10:13 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 spammy= X-HELO: us-smtp-delivery-1.mimecast.com Received: from us-smtp-1.mimecast.com (HELO us-smtp-delivery-1.mimecast.com) (207.211.31.81) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 13 Jan 2020 15:10:12 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1578928211; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+mfw1uw65jAd8WDgkfaM59TYNiDKzn/I8iUK5jeNk+0=; b=DqMBfSwOD82mGJ3+8GXZWa4wWD9eEOZJSJcr6Wl6CqqTUVT2udhfg4MobmtSaf9/0bqf7o Dv2XtFCsNMfka4Qajmk2i0+UOLGIDtNyGgWH4ZrmObv6dcCXmjW1O1X2MMmonKWD7xqjDf X7Dzln9KeoGbX0ZtmpvZGUp2Jc5XyQQ= Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-361-kAHI58XfOv6GxrJ6NiF6HA-1; Mon, 13 Jan 2020 10:10:09 -0500 Received: by mail-ed1-f69.google.com with SMTP id cy24so6396065edb.12 for ; Mon, 13 Jan 2020 07:10:09 -0800 (PST) Return-Path: Received: from ?IPv6:2001:8a0:f913:f700:4c97:6d52:2cea:997b? ([2001:8a0:f913:f700:4c97:6d52:2cea:997b]) by smtp.gmail.com with ESMTPSA id gl17sm462444ejb.72.2020.01.13.07.10.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 13 Jan 2020 07:10:07 -0800 (PST) Subject: Re: [PATCH v2 18/24] Multi-target support To: Simon Marchi , gdb-patches@sourceware.org, Andrew Burgess References: <20191017225026.30496-1-palves@redhat.com> <20191017225026.30496-19-palves@redhat.com> <113c6953-3621-c61b-e318-19806805e878@simark.ca> From: Pedro Alves Message-ID: <5a65f85e-89cb-fd6c-469d-250348f6c295@redhat.com> Date: Mon, 13 Jan 2020 15:19:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <113c6953-3621-c61b-e318-19806805e878@simark.ca> X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2020-01/txt/msg00325.txt.bz2 On 1/12/20 7:57 PM, Simon Marchi wrote: > On 2019-10-17 6:50 p.m., Pedro Alves wrote: >> This commit adds multi-target support to GDB. What this means is that >> with this commit, GDB can now be connected to different targets at the >> same time. E.g., you can debug a live native process and a core dump >> at the same time, connect to multiple gdbservers, etc. >> >> ... > > remote-sim.c needs to be updated to. The patch below makes it build, although > I have not tried it (I don't have time right now to re-figure out again how do > do it :)). > Sorry about this. I don't know how I missed it. The patch look good to me. One nit: > /* Callback for iterate_over_inferiors. Called (indirectly) by > gdbsim_close(). */ This comment is now stale. > > -static int > -gdbsim_close_inferior (struct inferior *inf, void *arg) > +void > +gdbsim_target::close_one_inferior (inferior *inf) > { Thanks, Pedro Alves