From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2072.outbound.protection.outlook.com [40.107.20.72]) by sourceware.org (Postfix) with ESMTPS id 341153858CDA for ; Mon, 19 Dec 2022 13:20:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 341153858CDA Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uBpodlknq95dt0jYxfvENUjtuuzJUzFF2VmeSB1eHEE=; b=39jLou9sTX8zVr7PHDj8vw7/t1RYnqactwRcodX6gzNgezEXgWRIDAayLXpHuOAL89Hqs1oXycx6TtXupFq9egadkLZgExF8XF/AGwy+KE+KWeQB4+PCIOVF2pPyZR9p/KaTjTGqQUsBtcOtwiHEDvZkkUd7DxQLca/UpZQbmdc= Received: from AS9PR06CA0458.eurprd06.prod.outlook.com (2603:10a6:20b:49a::10) by GV2PR08MB9207.eurprd08.prod.outlook.com (2603:10a6:150:d9::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.6; Mon, 19 Dec 2022 13:20:38 +0000 Received: from AM7EUR03FT024.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:49a:cafe::4d) by AS9PR06CA0458.outlook.office365.com (2603:10a6:20b:49a::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5924.20 via Frontend Transport; Mon, 19 Dec 2022 13:20:38 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT024.mail.protection.outlook.com (100.127.140.238) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5924.16 via Frontend Transport; Mon, 19 Dec 2022 13:20:37 +0000 Received: ("Tessian outbound 8038f0863a52:v132"); Mon, 19 Dec 2022 13:20:37 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 5f1c35f540acc942 X-CR-MTA-TID: 64aa7808 Received: from a3b30730cfbf.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 8081B21E-7C10-4611-9A5A-5957510D1D98.1; Mon, 19 Dec 2022 13:20:30 +0000 Received: from EUR02-AM0-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id a3b30730cfbf.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 19 Dec 2022 13:20:30 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QDJrQeSP67Ub7Llrhb7UGDD9wDos6evQGq24C8+doxQ/jzDz9wNSpESixy3/zKaTtNW7UN33da7smpisJrn8ABuY4Q0sMpmx8D+ztaWMB90qkVIuvpUmKVAFCMEzO9YtEZzTco61G1dn6djHwHIKI00AfA2LldWXCTzGDQZVG49GsTtcjMnKz9L7mDhU3A5BPWvECn669/ISEGIK56PIt1XzRl3ASTP8LoNL+30e0cmSB2b7Sshy8Oeb/UMqunnzC8dYlaUnokAYSmpO3koZWLeCgqtNoX2zdo4sYUl5yNw/BGsKjnB/sPWZKMZFvp1nn//6WmNAP5EcqJhMMcRNQA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uBpodlknq95dt0jYxfvENUjtuuzJUzFF2VmeSB1eHEE=; b=L+83lvaKhKlCgmTVFYV33jE1if3zHL3buMVqYc7VgpYJPjmQJcUjHQE+Ty6YA1gNIOCTkWnEVuIdV+Zq3XBKm6i9mwG/HvnbWorrt8DO8bDqDaXsbaZL1olER2Wju5TGnBule5JqUoq9rueHAhc4ahVaFqPhBBHDgzfeeA32XNU7TJBAy7b7yfGOlVFBHl1F6415aK3nrA9Og+KmbM8oUbfmQrbyFOZL4i9yyshrlZ9E6xrvnss3T8aCep15lTYmW4H/LBIkenB1jwawxfyGtcHM8y/twVFh1IqPJ2Uu7ffawPc8KMaayl2K1ZbINvJdVBacAt7LKzi0ttx7LEhZ8g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uBpodlknq95dt0jYxfvENUjtuuzJUzFF2VmeSB1eHEE=; b=39jLou9sTX8zVr7PHDj8vw7/t1RYnqactwRcodX6gzNgezEXgWRIDAayLXpHuOAL89Hqs1oXycx6TtXupFq9egadkLZgExF8XF/AGwy+KE+KWeQB4+PCIOVF2pPyZR9p/KaTjTGqQUsBtcOtwiHEDvZkkUd7DxQLca/UpZQbmdc= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) by AM8PR08MB5729.eurprd08.prod.outlook.com (2603:10a6:20b:1de::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.6; Mon, 19 Dec 2022 13:20:29 +0000 Received: from VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::eed7:25a3:e4ea:187a]) by VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::eed7:25a3:e4ea:187a%7]) with mapi id 15.20.5944.006; Mon, 19 Dec 2022 13:20:29 +0000 Message-ID: <5a78504a-8652-55c6-75ff-db6e0ab06690@arm.com> Date: Mon, 19 Dec 2022 13:20:27 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH 2/2] gdb/testsuite: new test for recent dwarf reader issue Content-Language: en-US To: Andrew Burgess , Tom Tromey , Andrew Burgess via Gdb-patches References: <87lengh250.fsf@tromey.com> <875yek2xdo.fsf@redhat.com> <286c40e2-3bde-91f2-32a2-485b6243bc93@arm.com> <877cys29o6.fsf@redhat.com> From: Luis Machado In-Reply-To: <877cys29o6.fsf@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0315.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:197::14) To VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: VI1PR08MB3919:EE_|AM8PR08MB5729:EE_|AM7EUR03FT024:EE_|GV2PR08MB9207:EE_ X-MS-Office365-Filtering-Correlation-Id: 25f654e0-008f-413b-4ecc-08dae1c3d1ad x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: hZamYyq1jF5HPa5ny1HVhaJbbex8cRM5dlEOsjX/e7M0hkjFD4zBF8c89cF1E1IF5n9x7g8978w+YPnFWezAbWuW7hqaT4jZ+5sCUkX4nBqurdW6kAgUqYijYh0D1+qAN5MtkldqPoIPbVqhaOVysCF+9zgHoMPJ6mb7tTVhpxzOltA+O8kKR/mAm0KB/2zWx/la+Md4dE5ApBO9+h/BRpFtOu3r/pMS5IsI5XXFnIfh1V5PtWLQYWLOihGZ35DyntDxyXqJOX8C/mGKYPUUnIk6kw8ovbsT+PltWC3LidF2ch9menCkul9EDTuejg/EyrCaG/M9n4vf3HcYypP7gb0ocWO/FVDQqPd98uKPgh56Q2K46ybhKZc2IEFmDQW+Bl4U0ZkVhRw+pBJoC6pdxDElacPW+WSM98pZnsj1/fPpqAfIKIg4Mf0LbkPlnFVCKW+yC4t/Z70vsh3H2FwTt1u9J1lqnGap6KdfEDdVyUG0E7K3jpLXxf3R1f/V2ThCRgRHzbS6O4FUZuZJVTvJp7qj0chLDIYxZJGUvBa6Q1porZXlWf64sHqK0xbqXBdTAfz3erg3+kHp2thVYkr+52Nxn5HazGGhpMb1SY9TTfwxgW/sm6rGoEl0jKcxPVdSe0XUhs2WW0cSz5NGftX4ZnJGOo15I8maNSLnLjDhnv8XgA1JjgjJqEzsComnhgyuB6yttlSS0Qv9eIRvIv/tsM3RKbuuu1qEZ11/QvsyOPg= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR08MB3919.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(366004)(346002)(396003)(136003)(376002)(451199015)(110136005)(2906002)(316002)(2616005)(31696002)(83380400001)(478600001)(6512007)(53546011)(6506007)(86362001)(36756003)(26005)(6486002)(38100700002)(186003)(44832011)(66899015)(66556008)(66476007)(5660300002)(8676002)(66946007)(31686004)(8936002)(41300700001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR08MB5729 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT024.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 1b2caca1-9f88-4e02-3f69-08dae1c3cbd6 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: /gMeHBOhMgMhw8m0yZzokXtG5+l6Ajg5o1TnDcLXFrdnhV7dG8OEvvKRMI6GDMSzc9Z+szfT8pe18tADgeberiGN1uCuYfgcfG6aZY4w3JBAujsn6XYOZ+QTzGfUkQ/dYDpzugfOwyUDLkTGYrmHieN9fO8aG+H0iqaO9cphvE5rP1jyef/0+AAXIXrMRHCzcDurJz372GsnFDdk/1K973kEJgxv5y4bzDe4xclfCzwFrllTTbU86uPkKsJWPEjmw23rANq0+p1iu7QQCvro8jMzjaz3ftS3LDMAuy6upm5IePvnt26Ll7VFljojE458ga2CFhD2xFP00P3uuvakdCeUcgfrF9CIGWtOqYATqAKxcup5otAxuY93ojZqdHFQ0JP/MNOZR/AAyhqhXh0h+azxJ6MCp5dNm8nIisT2rwQdB6BOf3atntZNxuR4ufBwDnWBX5Iq1I6kSBXLbqfuf2PdcM/FEuxZQ5RpIH8x7SzhiNJROJsLZ9IgTsCAE+GMO0xWXB5whqH3Yjt75jspRaQewGrEZoMh8RZIy95nfdKzmOAkDcupmu07B3WHgxjcYVQ6sR+DRcF+9NSF0UDIFhztYUBEY1iMotFzSEBlWvb4L4Fl3xroLNJ6TH4VGjPcs+RSUzT9RiRs2Z8sClI4omoivdfKkkZkjBxvj/bhB43j76v61z+OXls8FzhmZE1tyhza3d9DLFkGZrRNdJp88G0juq8B8krWkbLSGcCbqwA= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(136003)(376002)(346002)(396003)(451199015)(40470700004)(46966006)(36840700001)(36860700001)(44832011)(8936002)(82740400003)(2906002)(66899015)(31686004)(36756003)(40460700003)(316002)(40480700001)(336012)(47076005)(2616005)(6486002)(86362001)(82310400005)(356005)(478600001)(81166007)(31696002)(83380400001)(5660300002)(70586007)(70206006)(41300700001)(110136005)(53546011)(6506007)(186003)(26005)(8676002)(6512007)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Dec 2022 13:20:37.8389 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 25f654e0-008f-413b-4ecc-08dae1c3d1ad X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT024.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV2PR08MB9207 X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,FORGED_SPF_HELO,KAM_DMARC_NONE,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,TXREP,UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 12/15/22 11:22, Andrew Burgess wrote: > Luis Machado writes: > >> Hi Andrew, >> >> On 12/9/22 19:24, Andrew Burgess via Gdb-patches wrote: >>> Tom Tromey writes: >>> >>>>>>>>> "Andrew" == Andrew Burgess via Gdb-patches writes: >>>> >>>> Thank you for doing this. >>>> >>>> Andrew> - However, GDB checks each partial symbol using multiple languages, >>>> Andrew> not just the current language (C in this case), so, when GDB >>>> Andrew> checks using the C++ language, the symbol name is first demangled, >>>> Andrew> the code that does this can be found >>>> Andrew> lookup_name_info::language_lookup_name. As the demangled form of >>>> Andrew> 'signed int' is just 'int', GDB then looks for any symbols with >>>> Andrew> the name 'int', most partial symtabs will contain such a symbol, >>>> Andrew> so GDB ends up expanding pretty much every symtab. >>>> >>>> It's a pedantic point but what happens here is name canonicalization, >>>> not demangling. Demangling is just used to refer to the translation >>>> from a name like "_Zmumble" to "something::else" -- that is, the input >>>> is a linkage name and the output is a C++ name. Canonicalization takes >>>> a C++ name as input and returns the standard form, basically dealing >>>> with the fact that C++ (and as we discovered, C) has multiple possible >>>> spellings for some symbols. >>> >>> Please, be pedantic. My goal here was to better understand this code, >>> there's no point me understanding it wrong. >>> >>> I'll reword that paragraph. >>> >>> Thanks for taking a look. >>> >>> Andrew >>> >> >> I'm not saying you should investigate this, as it is a new test, but I'm getting a lot of these messages for this test: >> >> ERROR: internal buffer is full. > > Happy to take a look at the problem. > > I guess the issue is coming from the gdb_test_multiple that I use in the > new test script. > > I'm tried to write patterns that match and discard all the lines as they > arrive from GDB. I guess you are seeing a pattern that I am not for > some reason. > > Could you run just this test and attach the gdb.log file and I'll take a > look. I probably just need to tweak one of the patterns a little. > > Thanks, > Andrew > I briefly looked into this. The problem seems to arise from the fact that sometimes we don't have multiple lines for the "info sources" output. Some sections are output in a single line. For example, one of them has 133K characters. But each entry seems to be separated by a comma character: ./elf/./elf/rtld.c, ./elf/../include/rtld-malloc.h, ./elf/../sysdeps/generic/ldsodefs.h, ./elf/../sysdeps/aarch64/dl-machine.h, ... It might be best (for the testsuite) if gdb outputs this data across more lines.