From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 1DDE9383D020 for ; Mon, 5 Jul 2021 19:27:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1DDE9383D020 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 165JRP5U031752 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 5 Jul 2021 15:27:30 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 165JRP5U031752 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id F3CC81E939; Mon, 5 Jul 2021 15:27:24 -0400 (EDT) Subject: Re: [PATCH 03/10] remote+gdbserver: stepped-thread-exited feature To: Pedro Alves , gdb-patches@sourceware.org Cc: Simon Marchi References: <20210702130154.1947858-1-pedro@palves.net> <20210702130154.1947858-4-pedro@palves.net> From: Simon Marchi Message-ID: <5aa3175b-ecbb-d37b-ed1b-8b07cdba46b2@polymtl.ca> Date: Mon, 5 Jul 2021 15:27:24 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210702130154.1947858-4-pedro@palves.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Mon, 5 Jul 2021 19:27:25 +0000 X-Spam-Status: No, score=-10.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Jul 2021 19:27:39 -0000 > diff --git a/gdbserver/target.h b/gdbserver/target.h > index 2c4393ec8c6..862300f72f5 100644 > --- a/gdbserver/target.h > +++ b/gdbserver/target.h > @@ -500,6 +500,10 @@ class process_stratum_target > /* Returns true if the target supports memory tagging facilities. */ > virtual bool supports_memory_tagging (); > > + /* Returns true if the target supports returning > + TARGET_WAITKIND_THREAD_EXITED for stepping threads. */ > + virtual bool supports_stepped_thread_exited(); Space before parens. Otherwise, LGTM. Simon