From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 46362 invoked by alias); 27 Jun 2017 18:37:08 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 45860 invoked by uid 89); 27 Jun 2017 18:37:07 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=BAYES_00,RCVD_IN_SORBS_SPAM,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=no version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 27 Jun 2017 18:37:06 +0000 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 88281FEEF0; Tue, 27 Jun 2017 18:37:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 88281FEEF0 Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=palves@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 88281FEEF0 Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4EE1378DD4; Tue, 27 Jun 2017 18:37:03 +0000 (UTC) Subject: Re: [RFA] Make "bt N" print correct number of frames when using a frame filter To: Tom Tromey , gdb-patches@sourceware.org References: <20170423160446.17062-1-tom@tromey.com> From: Pedro Alves Message-ID: <5aa8225f-70d1-2e69-9280-ca527b2ea981@redhat.com> Date: Tue, 27 Jun 2017 18:37:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20170423160446.17062-1-tom@tromey.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-06/txt/msg00746.txt.bz2 On 04/23/2017 05:04 PM, Tom Tromey wrote: > PR python/16497 notes that using "bt" with a positive argument prints > the wrong number of frames when a frame filter is in use. Also, in this > case, the non-frame-filter path will print a message about "More stack > frames" when there are more; but this is not done in the frame-filter > case. > > The first problem is that backtrace_command_1 passes the wrong value > to apply_ext_lang_frame_filter -- that function takes the final > frame's number as an argument, but backtrace_command_1 passes the > count, which is off by one. > > The solution to the second problem is to have the C stack-printing > code stop at the correct number of frames and then print the message. > > Tested using the buildbot. Can you expand on the need for the PRINT_MORE_FRAMES flag and having it based on from_tty? I assume that your first made the printing unconditional, but then for some reason decided against it? Thanks, Pedro Alves