public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Simon Marchi <simark@simark.ca>
To: Mihails Strasuns <mihails.strasuns@intel.com>,
	gdb-patches@sourceware.org
Subject: Re: [PATCH v3 1/9] [gdb/testsuite] allow more registers in reader test
Date: Fri, 17 Apr 2020 22:30:45 -0400	[thread overview]
Message-ID: <5abb1182-cebd-34be-c782-02afa62097e6@simark.ca> (raw)
In-Reply-To: <20200331171356.26126-1-mihails.strasuns@intel.com>

On 2020-03-31 1:13 p.m., Mihails Strasuns via Gdb-patches wrote:
> Fixes jit-reader test failures on systems that have more registers than
> expected by the current condition.
> 
> On Intel i9-7920X the following extra registers are printed:
> 
> k0             0x0                 0
> k1             0x0                 0
> k2             0x0                 0
> k3             0x0                 0
> k4             0x0                 0
> k5             0x0                 0
> k6             0x0                 0
> k7             0x0                 0
> 
> gdb/testsuite/ChangeLog:
> 
> 2020-02-18  Mihails Strasuns  <mihails.strasuns@intel.com>
> 
> 	* gdb.base/jit-reader.exp: relax register output check

Please start with capital letter and end with a period.

> Signed-off-by: Mihails Strasuns <mihails.strasuns@intel.com>
> Change-Id: I227ab8691b2363d626f7100216477ab637f619fa

Update the commit title to mention jit, just saying "reader test" is vague.  Might as well
mention the test filename:

  allow more registers in gdb.bas/jit-reader.exp

This patch is ok to push by itself with those fixed.  Please remind me, do you have push
access, or do you need/want it?  If not I don't mind pushing for you.

Simon


      parent reply	other threads:[~2020-04-18  2:30 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <166773>
2020-03-31 17:13 ` Mihails Strasuns
2020-03-31 17:13   ` [PATCH v3 2/9] [gdb/testsuite] structured rename of jit test files Mihails Strasuns
2020-04-18  2:35     ` Simon Marchi
2020-03-31 17:13   ` [PATCH v3 3/9] [gdb/testsuite] share jit-protocol.h by all jit tests Mihails Strasuns
2020-04-18  2:38     ` Simon Marchi
2020-03-31 17:13   ` [PATCH v3 4/9] [gdb/testsuite] use args as lib list for jit-elf tests Mihails Strasuns
2020-04-18  2:58     ` Simon Marchi
2020-04-20  7:35       ` Strasuns, Mihails
2020-04-20 13:08         ` Simon Marchi
2020-04-20 13:53           ` Simon Marchi
2020-03-31 17:13   ` [PATCH v3 5/9] [gdb/testsuite] add lib/jit-elf-helpers.exp Mihails Strasuns
2020-03-31 17:13   ` [PATCH v3 6/9] [gdb/testsuite] use -Ttext-segment for jit-elf tests Mihails Strasuns
2020-03-31 17:13   ` [PATCH v3 7/9] [gdb/testsuite] define jit function name via macro Mihails Strasuns
2020-03-31 17:13   ` [PATCH v3 8/9] [gdb/testsuite] add jit-elf-util.h and run jit function Mihails Strasuns
2020-03-31 17:13   ` [PATCH v3 9/9] [gdb/testsuite] handle compilation failures in jit-elf-helpers Mihails Strasuns
2020-04-14 10:08   ` [PATCH v3 1/9] [gdb/testsuite] allow more registers in reader test Strasuns, Mihails
2020-04-18  2:30   ` Simon Marchi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5abb1182-cebd-34be-c782-02afa62097e6@simark.ca \
    --to=simark@simark.ca \
    --cc=gdb-patches@sourceware.org \
    --cc=mihails.strasuns@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).