From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) by sourceware.org (Postfix) with ESMTPS id 534E0396E048 for ; Thu, 14 May 2020 18:14:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 534E0396E048 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=alves.ped@gmail.com Received: by mail-wr1-f67.google.com with SMTP id l11so5609751wru.0 for ; Thu, 14 May 2020 11:14:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=gJOagyW3czLgKR14q5X/XStzhkuhFqvA4ponZAxotDM=; b=Y1AZkTi2oCPPRkmkhgSJTo3GdrTm1A7NivtxapZct/dZGiMeAKOv8zAiUyGw46/oji Ip0mQ7xTLwa2NRY8Fa75DHGoZ/cmto5JLSiA7bUGTtfSn8WKwa5TNFW1Kqu1dXNSnA1B mXKa4d+k+yOoWN1E8w8nyYroHXN6CwDZIAuWA0Ysfsed53E8Vi1easNkZWZJqDTFecuj vRToNP4vss5bjsDuLVnitjBlwqr1iYPc6VB58zh+iRGgLNTs8e2aiF9dZBLyoxXtj8ww +RRYlWZhkqWUif2qMbFbtF624bfAFXSWigpo/PRLO/b5NEUuApyqlFggr3wDyB2caeAb PCFQ== X-Gm-Message-State: AOAM532+rbPhKIyLM1ETS5zWP++GBrJRs1jfGpF0IWRRbqPsoDQQQ2x+ EGigXi3pDg8qKDCT9VB4MlEK9bNYPRGoVg== X-Google-Smtp-Source: ABdhPJxjM4FMelCpRmpo2yPFjKVUX7Bg1bXmDirjeT7ZeB/vI1QIslOGdgBNLoes6MbKwnEiFMbkug== X-Received: by 2002:adf:bc41:: with SMTP id a1mr7271521wrh.302.1589480076341; Thu, 14 May 2020 11:14:36 -0700 (PDT) Received: from ?IPv6:2001:8a0:f909:7b00:56ee:75ff:fe8d:232b? ([2001:8a0:f909:7b00:56ee:75ff:fe8d:232b]) by smtp.gmail.com with ESMTPSA id g187sm12152742wmf.30.2020.05.14.11.14.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 14 May 2020 11:14:35 -0700 (PDT) Subject: Re: [PATCH v2] gdb: infrun: consume multiple events at each pass in stop_all_threads To: Simon Marchi , "Aktemur, Tankut Baris" , Simon Marchi , "gdb-patches@sourceware.org" References: <20200224193638.29578-1-simon.marchi@efficios.com> <8402549f-c733-cb8b-918c-4dfb06eeb7a0@redhat.com> <80775539-f358-874b-df16-1e8642e082ca@simark.ca> Cc: Laurent Morichetti From: Pedro Alves Message-ID: <5ac9bb7a-6bf0-401f-909e-54d98739685b@palves.net> Date: Thu, 14 May 2020 19:14:34 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <80775539-f358-874b-df16-1e8642e082ca@simark.ca> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.5 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 May 2020 18:14:39 -0000 On 5/14/20 7:02 PM, Simon Marchi wrote: > Here's a rebased version. Thanks Simon. Please go ahead and merge. BTW, did you consider coming up with a mechanism similar to make_scoped_defer_target_commit_resume()/target_commit_resume() for target_stop, so that we could coalesce the multiple vCont;t requests in a single remote packet? That could also cut down on latency. (gdbserver's resume interface is better for that, in that a stop, continues and steps all go via the same interface: static void resume (struct thread_resume *actions, size_t num_actions) { I've pondered adjusting GDB's resume interface in a similar way. That would make target_commit_resume Just Work for stops too. ) Thanks, Pedro Alves